Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for each nREPL port file at each tree level #317

Closed
Olical opened this issue Feb 17, 2022 · 1 comment · Fixed by #324
Closed

Check for each nREPL port file at each tree level #317

Olical opened this issue Feb 17, 2022 · 1 comment · Fixed by #324
Labels
client-clojure enhancement New feature or request

Comments

@Olical
Copy link
Owner

Olical commented Feb 17, 2022

As Hukka over on Clojurians slack pointed out, Conjure will pick the Clojure .nrepl-port file over the shadow-cljs one if a single .nrepl-port exists anywhere up your directory tree, so it's hunting for that first then shadow-cljs if it can't find one. It should instead check each directory for each file in priority order.

The priority remains the same (Clojure then ClojureScript) but it should check for each in each directory as it travels, instead of travelling upwards twice.
@Olical Olical added enhancement New feature or request client-clojure labels Feb 17, 2022
stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 21, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
244c203
@stelcodes stelcodes mentioned this issue Mar 21, 2022
Merged
stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 21, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
379babe
@stelcodes
Copy link
Contributor

Hi there @Olical, I'm not sure if you've already been working on this but I posted a rough draft PR for this issue.

stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 22, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
11cdd84
stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 22, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
73d3f08
stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 22, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
00b586c
stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 22, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
d7a169c
stelcodes added a commit to stelcodes/conjure that referenced this issue Mar 22, 2022
@stelcodes
Check for each nREPL port file at each tree level (Olical#317)
1023190
Olical added a commit that referenced this issue Mar 26, 2022
@Olical
Merge branch 'stelcodes-gh-317' into develop
6ac2d8f
@Olical Olical closed this as completed Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client-clojure enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for each nREPL port file at each tree level (#317) stelcodes/conjure
2 participants
@Olical @stelcodes