-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can Conjure be configured to be silent (i.e. no popup) when starting? #51
Comments
So interestingly I was thinking about this exact thing. I think I might
move away from tagging them as out and use start tagging as conjure/conns
or something. Maybe conjure/up, just like how test output goes to
conjure/test.
But then if you turned off conjure/up you'd never see them / it's never pop
the log open. Unless you maybe rebound so you had your own mapping that
opened the log then ran up?
What do you think?
…On Wed, 17 Jul 2019, 17:54 Dave Yarwood, ***@***.***> wrote:
As I've been using Conjure, I've been noticing that I tend to reflexively
press <localleader>cq to close the initial Conjure log that pops up and
tells me the results of its trying to connect to any prepls as configured
in conjure.edn:
; conjure/out | Welcome to Conjure! (v0.22.0-0-g0cbb94a56f)
; conjure/out | Adding :cwd
In practice, I don't care about these results upon starting Neovim, and I
assume that it's just going to work when I'm ready to use it. (And if it
doesn't work, I'll find out anyway!)
So I'm wondering, is there any way to configure Conjure not to pop up
initially? I realize this is a bit complicated, because under the hood it's
probably just doing what it always does with :out messages. And I *do*
want the Conjure log to pop open for :out messages, in general, like if I
evaluate something that prints to STDOUT, or if I run :ConjureUp. It
would be nice, anyway. Thoughts welcome. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AACM6XMPK6OXBB6TCRDABP3P75FCXA5CNFSM4IESPSJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7ZPPVQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACM6XJMDWZDGQDU4FDHVU3P75FCXANCNFSM4IESPSJQ>
.
|
I like the idea of tagging that output as Rebinding
|
So I've split Let me know how you get on with this first 😃 |
Something about how this is split up and configured smells to me right now, but I'll mull it over. Maybe I need to flip that list over so you choose what you don't want to see? |
"Everything by default" does sound good to me. Maybe that implies a separate config var like I tried the I think the next step is to have Conjure periodically re-up my connections, so that I never have to run |
Cool that all sounds good to me! I'm glad it works, and yeah, you shouldn't have to see the log when you I think if I add a blacklist I may well just do a breaking change and remove the existing config while it's still < 1.0.0. Having that legacy forever after 1.0.0 will be a little gross I think, especially if I think it's not the best UX and the interaction with the new config will be... questionable. Like what happens if you set both. I think I'll swap it to a blacklist and document it well for the next release. Or I'll call it "suppress" maybe. Not sure about running |
You're actually in a great position as the author of a plugin that's oriented around a log. Whenever you want to make a breaking change, if you want, you can follow a deprecation process where you notice when users are doing the old thing and print a warning to the log. In this case, for example, you could recognize when the old config variable is set and print a deprecation warning. |
Good point, might go down that route so it sticks around for a while then
I'll have a prune sometimes.
…On Thu, 18 Jul 2019, 16:18 Dave Yarwood, ***@***.***> wrote:
You're actually in a great position as the author of a plugin that's
oriented around a log. Whenever you want to make a breaking change, if you
want, you can follow a deprecation process where you notice when users are
doing the old thing and print a warning to the log. In this case, for
example, you could recognize when the old config variable is set and print
a deprecation warning.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AACM6XJ6RKREXUWCBSAW3FDQACCTJA5CNFSM4IESPSJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2I2JGI#issuecomment-512861337>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACM6XK4Q25CWU6J7WULNB3QACCTJANCNFSM4IESPSJQ>
.
|
Okay, Should solve your issues fairly nicely? I know it's a breaking change but I think it's for the best. Like a plaster, better to rip it off quickly. |
I like it. I went through and figured out what I need in my blacklist to get the equivalent of my current whitelist: let g:conjure_log_blacklist = ["up", "eval", "ret", "load-file"] I like this because the intent reads much clearer than with the whitelist version. 👍 One thing you might consider before this gets pushed to master: the name "conjure log blacklist" might imply that it's a list of things not to include in the log, vs. what it really is, which is a list of things that should not result in the log popping open. As such, I think |
As I've been using Conjure, I've been noticing that I tend to reflexively press
<localleader>cq
to close the initial Conjure log that pops up and tells me the results of its trying to connect to any prepls as configured in conjure.edn:In practice, I don't care about these results upon starting Neovim, and I assume that it's just going to work when I'm ready to use it. (And if it doesn't work, I'll find out anyway!)
So I'm wondering, is there any way to configure Conjure not to pop up initially? I realize this is a bit complicated, because under the hood it's probably just doing what it always does with
:out
messages. And I do want the Conjure log to pop open for:out
messages, in general, like if I evaluate something that prints to STDOUT, or if I run:ConjureUp
. It would be nice, anyway. Thoughts welcome. :)The text was updated successfully, but these errors were encountered: