You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I am super excited about conjure. It looks like a pretty sweet plugin for integrating prepl (especially clojurescript) into neovim. Everything seems to be working like a charm except for this weird edge case I ran into.
The issue happens when I try to eval a ns form in clojurescript that hasn't been eval'd before. I found eval-str and noticed that conjure unconditionally wraps all code in a do form.
This probably works in almost all use cases except the one I mentioned above. The clojurescript compiler seems to be emitting different code if ns is wrapped in a do form. This causes issues resolving the ns dependencies unlinke if it were a top level form.
I would be open to providing a PR but wanted to bring up the issue for discussion first, thanks.
The text was updated successfully, but these errors were encountered:
Thank you for opening an issue first! I'm off to sleep now but I'll think on this a little and get back to you with my thoughts ASAP. Maybe we can avoid the do without breaking anything else 🤔
Check out the develop branch, I've pushed a commit that'll only wrap ClojureScript evals if it thinks there's more than one form or it can't work out how many there are. So if you send a single form it'll remove the (do ...) wrapped. Maybe that'll fix it? If not, it'll be the in-ns switching.
Also worth noting that CLJS exceptions will be ugly data that just gets returned as a result to you until someone merges and releases my prepl patch: https://clojure.atlassian.net/browse/CLJS-3096
As soon as that's in you'll get nicely formatted errors, just like Clojure.
Hello, I am super excited about conjure. It looks like a pretty sweet plugin for integrating prepl (especially clojurescript) into neovim. Everything seems to be working like a charm except for this weird edge case I ran into.
The issue happens when I try to eval a
ns
form in clojurescript that hasn't been eval'd before. I found eval-str and noticed that conjure unconditionally wraps all code in ado
form.This probably works in almost all use cases except the one I mentioned above. The clojurescript compiler seems to be emitting different code if
ns
is wrapped in ado
form. This causes issues resolving thens
dependencies unlinke if it were a top level form.I would be open to providing a PR but wanted to bring up the issue for discussion first, thanks.
The text was updated successfully, but these errors were encountered: