[WIP] Refactor and improve Common Lisp client #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotrar
changed the title
|
So what state would you say this is in right now? Still an improvement on what is there right now even if there's more you'd like to do? If you're kinda happy with how it behaves I'll be happy to merge and get it in the hands of users. Future changes are still of course welcome! 😄 |
|
Oh actually this would be a breaking change right? Because it requires a different transport so the user would have to start their REPL differently? |
Dotrar
force-pushed
the
slynk-transport
branch
from
2094b7b
to
c9be9b1
Compare
|
closing this PR because it's messy and out of date. changing to slynk was a lot easier than i was expecting, check out my new PR here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to improve the Common Lisp client, mainly by refactoring the code and making it easier to read, and changing to the
slynkclient that is a more modern and maintained version ofslimefor common lisp.TODO:
remote.transport.slynkcommon-lisp.utilsswank-y code.