Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result refactor #47

Merged
merged 7 commits into from
Jul 5, 2019
Merged

Result refactor #47

merged 7 commits into from
Jul 5, 2019

Conversation

Olical
Copy link
Owner

@Olical Olical commented Jul 4, 2019

Mostly done! This branch greatly improves how errors are caught and handled within Conjure. I've made sure caught exceptions get logged too which should make debugging in the future easier when someone breaks Conjure. The whole plugin should be more robust in weird edge cases now, time for me to test it out for a while!

A few more small things:

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #47 into develop will decrease coverage by 2.66%.
The diff coverage is 8.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #47      +/-   ##
==========================================
- Coverage    35.56%   32.9%   -2.67%     
==========================================
  Files           12      11       -1     
  Lines         1029    1018      -11     
  Branches        47      47              
==========================================
- Hits           366     335      -31     
- Misses         616     636      +20     
  Partials        47      47
Impacted Files Coverage Δ
src/conjure/nvim.clj 60.49% <0%> (ø) ⬆️
src/conjure/ui.clj 17.85% <0%> (-1.38%) ⬇️
src/conjure/prepl.clj 8.92% <0%> (+0.66%) ⬆️
src/conjure/action.clj 10.17% <1.2%> (-1.34%) ⬇️
src/conjure/util.clj 94.91% <100%> (ø) ⬆️
src/conjure/code.clj 28.57% <54.54%> (-7.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630bcd1...b93dd6c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #47 into develop will decrease coverage by 2.66%.
The diff coverage is 8.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #47      +/-   ##
==========================================
- Coverage    35.56%   32.9%   -2.67%     
==========================================
  Files           12      11       -1     
  Lines         1029    1018      -11     
  Branches        47      47              
==========================================
- Hits           366     335      -31     
- Misses         616     636      +20     
  Partials        47      47
Impacted Files Coverage Δ
src/conjure/nvim.clj 60.49% <0%> (ø) ⬆️
src/conjure/ui.clj 17.85% <0%> (-1.38%) ⬇️
src/conjure/prepl.clj 8.92% <0%> (+0.66%) ⬆️
src/conjure/action.clj 10.17% <1.2%> (-1.34%) ⬇️
src/conjure/util.clj 94.91% <100%> (ø) ⬆️
src/conjure/code.clj 28.57% <54.54%> (-7.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc4561...6d57e31. Read the comment docs.

@Olical
Copy link
Owner Author

Olical commented Jul 5, 2019

Yeah, whatever, codecov. You can whine all you want but I know it's okay. I'll get you a high test coverage percentage some day, my angry GitHub integration ❤️

@Olical Olical merged commit 36397ed into develop Jul 5, 2019
@Olical Olical deleted the result-refactor branch July 5, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant