-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result refactor #47
Result refactor #47
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #47 +/- ##
==========================================
- Coverage 35.56% 32.9% -2.67%
==========================================
Files 12 11 -1
Lines 1029 1018 -11
Branches 47 47
==========================================
- Hits 366 335 -31
- Misses 616 636 +20
Partials 47 47
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #47 +/- ##
==========================================
- Coverage 35.56% 32.9% -2.67%
==========================================
Files 12 11 -1
Lines 1029 1018 -11
Branches 47 47
==========================================
- Hits 366 335 -31
- Misses 616 636 +20
Partials 47 47
Continue to review full report at Codecov.
|
Yeah, whatever, codecov. You can whine all you want but I know it's okay. I'll get you a high test coverage percentage some day, my angry GitHub integration ❤️ |
Mostly done! This branch greatly improves how errors are caught and handled within Conjure. I've made sure caught exceptions get logged too which should make debugging in the future easier when someone breaks Conjure. The whole plugin should be more robust in weird edge cases now, time for me to test it out for a while!
A few more small things:
conjure.result
fromconjure.code/parse-ns
conjure.result