-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes in tools.deps #46
Comments
Thanks for the heads up! I'll leave this open until I address it. |
dotemacs
added a commit
to dotemacs/depot
that referenced
this issue
Dec 29, 2020
I updated it because I came across an issue where I had org.clojure/tools.deps.alpha {:mvn/version "0.9.857"} declared in a project's deps.edn. I used the setup as per the README in my ~/.clojure/deps.edn: :aliases {:outdated {:extra-deps {olical/depot {:mvn/version "2.0.1"}} :main-opts ["-m" "depot.outdated.main"]}} and I got an error: Syntax error (FileNotFoundException) compiling at (depot/outdated/update.clj:1:1). Could not locate clojure/tools/deps/alpha/reader__init.class, clojure/tools/deps/alpha/reader.clj or clojure/tools/deps/alpha/reader.cljc on classpath. Then collected the info about it and was about to create a new issue when I saw this issue about API change in tools.deps.alpha: Olical#46 and kind of "got distracted" and upgraded the dependencies, creating this PR. But really, all I had to do was change the above alias to: :aliases {:outdated {:replace-deps {olical/depot {:mvn/version "2.0.1"}} :main-opts ["-m" "depot.outdated.main"]}} NOTE: :replace-deps instead of :extra-deps.
Merged
Fixed by the linked PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just wanted to drop a note that the newest version of tools.deps.alpha contains some api changes (moving towards getting out of alpha). So when you bump to tools.deps.alpha >= 0.9.745, you'll need to change this:
In
depot.outdated.update
,(reader/read-deps (reader/default-deps))
should use something like(let [{:keys [root-edn user-edn project-edn]} (find-edn-maps)] (merge-edns [root-edn user-edn project-edn]))
(all fns in clojure.tools.deps.alpha).The text was updated successfully, but these errors were encountered: