Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install docker and openssh-client during image build. #13

Closed
Jafner opened this issue Jul 16, 2021 · 1 comment
Closed

Install docker and openssh-client during image build. #13

Jafner opened this issue Jul 16, 2021 · 1 comment
Labels
type: feature-request New feature request

Comments

@Jafner
Copy link

Jafner commented Jul 16, 2021

Is your feature request related to a problem? Please describe.
Attempting to run docker or ssh-based actions without installing these two fails.

Describe the solution you'd like
Add dnf install -y docker && dnf install -y openssh-client to Dockerfile.

Describe alternatives you've considered
Manually installing these services after the image has been deployed requires re-installation each time the container is created. In my use-case, where Docker Compose is used to statically define the container's configuration, adding a step after deployment is poor practice.

Additional context
I love OliveTin, and I hope I can contribute to its betterment.

@Jafner Jafner added the type: feature-request New feature request label Jul 16, 2021
@jamesread
Copy link
Collaborator

I gave this some re-thinking since it was mentioned in #12.

Using docker and ssh is a very common use case for OliveTin, and because the docker images are provided as a convenience, it makes sense to make them as convenient as possible.

Added in the latest updated container images that have now been published.

Thanks for the comment. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature-request New feature request
Development

No branches or pull requests

2 participants