Use luaossl instead of luacrypto.

jwt-0.5-2.rockspec

@@ -14,7 +14,7 @@ description = {
 dependencies = {
   "lua >= 5.1",
   "busted >= 1.7-1",
-  "luacrypto >= 0.3.2-1",
+  "luaossl >= 20151221-0",
   "lua-cjson-ol >= 1.0-1",
   "basexx >= 0.2.0-0"
 }

spec/jwt_spec.lua

@@ -1,7 +1,8 @@
 describe("JWT spec", function()
 
-  local jwt = require 'jwt'
-  local crypto = require 'crypto'
+  local jwt  = require 'jwt'
+  local crypto = pcall (require, 'crypto') and require 'crypto'
+  local pkey = require 'openssl.pkey'
   local plainJwt = "eyJhbGciOiJub25lIn0.eyJpc3MiOiJqb2UiLA0KICJleHAiOjEzMDA4MTkzODAsDQogImh0dHA6Ly9leGFtcGxlLmNvbS9pc19yb290Ijp0cnVlfQ"
 
   it("can decode a plain text token", function()
@@ -46,21 +47,104 @@ describe("JWT spec", function()
       test = "test",
       empty={},
     }
-    local keyPair = crypto.pkey.generate("rsa", 512)
-    local token, err = jwt.encode(claims, {alg = "RS256", keys = {private = keyPair}})
-    local decodedClaims = jwt.decode(token, {keys = {public = keyPair}})
+    local keys = {
+      private =
+[[-----BEGIN RSA PRIVATE KEY-----
+MIIBOwIBAAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/D5z2A7KPYXUgUP0jd5yL
+Z7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQJBAJYXWNmw7Cgbkk1+v3C0
+dyeqHYF0UD5vtHLxs/BWLPI2lZO0e6ixFNI4uIuatBox1Zbzt1TSy8T09Slt4tNL
+CAECIQD6PHDGtKXcI2wUSvh4y8y7XfvwlwRPU2AzWZ1zvOCbbQIhANzgMpUNOZL2
+vakju4sal1yZeXUWO8FurmsAyotAx9tBAiB2oQKh4PAkXZKWSDhlI9CqHtMaaq17
+Yb5geaKARNGCPQIgILYrh5ufzT4xtJ0QJ3fWtuYb8NVMIEeuGTbSyHDdqIECIQDZ
+3LNCyR2ykwetc6KqbQh3W4VkuatAQgMv5pNdFLrfmg==
+-----END RSA PRIVATE KEY-----]],
+      public =
+[[-----BEGIN PUBLIC KEY-----
+MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/
+D5z2A7KPYXUgUP0jd5yLZ7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQ==
+-----END PUBLIC KEY-----]],
+    }
+    local token, _ = jwt.encode(claims, {alg = "RS256", keys = { private = keys.private }})
+    local decodedClaims = jwt.decode(token, {keys = { public = keys.public }})
     assert.are.same(claims, decodedClaims)
   end)
 
+  if crypto then
+    it("it cannot encode/decode a signed plain text token with alg=RS256 (using luacrypto pkey)", function()
+      local claims = {
+        test = "test",
+        empty={},
+      }
+      local key = crypto.pkey.generate("rsa", 512)
+      local private_key =
+[[-----BEGIN RSA PRIVATE KEY-----
+MIIBOwIBAAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/D5z2A7KPYXUgUP0jd5yL
+Z7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQJBAJYXWNmw7Cgbkk1+v3C0
+dyeqHYF0UD5vtHLxs/BWLPI2lZO0e6ixFNI4uIuatBox1Zbzt1TSy8T09Slt4tNL
+CAECIQD6PHDGtKXcI2wUSvh4y8y7XfvwlwRPU2AzWZ1zvOCbbQIhANzgMpUNOZL2
+vakju4sal1yZeXUWO8FurmsAyotAx9tBAiB2oQKh4PAkXZKWSDhlI9CqHtMaaq17
+Yb5geaKARNGCPQIgILYrh5ufzT4xtJ0QJ3fWtuYb8NVMIEeuGTbSyHDdqIECIQDZ
+3LNCyR2ykwetc6KqbQh3W4VkuatAQgMv5pNdFLrfmg==
+-----END RSA PRIVATE KEY-----]]
+      local token, _ = jwt.encode(claims, {alg = "RS256", keys = { private = private_key }})
+      assert.has.error (function ()
+        jwt.encode(claims, {alg = "RS256", keys = {private = key}})
+      end)
+      assert.has.error (function ()
+        jwt.decode(token, {keys = {public = key}})
+      end)
+    end)
+  end
+
+  it("it cannot encode/decode a signed plain text token with alg=RS256 (using luaossl pkey)", function()
+    local claims = {
+      test = "test",
+      empty={},
+    }
+    local key = pkey.new{type = "rsa", bits=512}
+    local private_key =
+[[-----BEGIN RSA PRIVATE KEY-----
+MIIBOwIBAAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/D5z2A7KPYXUgUP0jd5yL
+Z7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQJBAJYXWNmw7Cgbkk1+v3C0
+dyeqHYF0UD5vtHLxs/BWLPI2lZO0e6ixFNI4uIuatBox1Zbzt1TSy8T09Slt4tNL
+CAECIQD6PHDGtKXcI2wUSvh4y8y7XfvwlwRPU2AzWZ1zvOCbbQIhANzgMpUNOZL2
+vakju4sal1yZeXUWO8FurmsAyotAx9tBAiB2oQKh4PAkXZKWSDhlI9CqHtMaaq17
+Yb5geaKARNGCPQIgILYrh5ufzT4xtJ0QJ3fWtuYb8NVMIEeuGTbSyHDdqIECIQDZ
+3LNCyR2ykwetc6KqbQh3W4VkuatAQgMv5pNdFLrfmg==
+-----END RSA PRIVATE KEY-----]]
+    local token, _ = jwt.encode(claims, {alg = "RS256", keys = { private = private_key }})
+    assert.has.error (function ()
+      jwt.encode(claims, {alg = "RS256", keys = {private = key}})
+    end)
+    assert.has.error (function ()
+      jwt.decode(token, {keys = {public = key}})
+    end)
+  end)
+
   it("it cannot encode/decode a signed plain text token with alg=RS256 and an incorrect key", function()
     local claims = {
       test = "test",
     }
-    local keyPair = crypto.pkey.generate("rsa", 512)
-    local badPair = crypto.pkey.generate("rsa", 512)
-    local token = jwt.encode(claims, {alg = "RS256", keys = {private = keyPair}})
-    local decodedClaims = jwt.decode(token, {keys = {public = badPair}})
-    assert.has_error(function() assert.are.same(claims, decodedClaims) end)
+    local keys = {
+      private =
+[[-----BEGIN RSA PRIVATE KEY-----
+MIIBOwIBAAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/D5z2A7KPYXUgUP0jd5yL
+Z7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQJBAJYXWNmw7Cgbkk1+v3C0
+dyeqHYF0UD5vtHLxs/BWLPI2lZO0e6ixFNI4uIuatBox1Zbzt1TSy8T09Slt4tNL
+CAECIQD6PHDGtKXcI2wUSvh4y8y7XfvwlwRPU2AzWZ1zvOCbbQIhANzgMpUNOZL2
+vakju4sal1yZeXUWO8FurmsAyotAx9tBAiB2oQKh4PAkXZKWSDhlI9CqHtMaaq17
+Yb5geaKARNGCPQIgILYrh5ufzT4xtJ0QJ3fWtuYb8NVMIEeuGTbSyHDdqIECIQDZ
+3LNCyR2ykwetc6KqbQh3W4VkuatAQgMv5pNdFLrfmg==
+-----END RSA PRIVATE KEY-----]],
+      public =
+[[-----BEGIN PUBLIC KEY-----
+MQwwDQYJKoZIhvcNAQEBBQADSwAwSAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/
+D5z2A7KPYXUgUP0jd5yLZ7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQ==
+-----END PUBLIC KEY-----]],
+    }
+    local token = jwt.encode(claims, {alg = "RS256", keys = { private = keys.private }})
+    local decodedClaims = jwt.decode(token, {keys = { public = keys.public }})
+    assert.are_not.same(claims, decodedClaims)
   end)
 
   it("can verify a signature", function()
@@ -88,7 +172,7 @@ EQIDAQAB
 
   it("can encode and decode rs256", function()
     local keys = {
-      private = crypto.pkey.from_pem(
+      private =
 [[-----BEGIN RSA PRIVATE KEY-----
 MIIBOwIBAAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/D5z2A7KPYXUgUP0jd5yL
 Z7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQJBAJYXWNmw7Cgbkk1+v3C0
@@ -97,12 +181,12 @@ CAECIQD6PHDGtKXcI2wUSvh4y8y7XfvwlwRPU2AzWZ1zvOCbbQIhANzgMpUNOZL2
 vakju4sal1yZeXUWO8FurmsAyotAx9tBAiB2oQKh4PAkXZKWSDhlI9CqHtMaaq17
 Yb5geaKARNGCPQIgILYrh5ufzT4xtJ0QJ3fWtuYb8NVMIEeuGTbSyHDdqIECIQDZ
 3LNCyR2ykwetc6KqbQh3W4VkuatAQgMv5pNdFLrfmg==
------END RSA PRIVATE KEY-----]], true),
-      public = crypto.pkey.from_pem(
+-----END RSA PRIVATE KEY-----]],
+      public =
 [[-----BEGIN PUBLIC KEY-----
 MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/
 D5z2A7KPYXUgUP0jd5yLZ7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQ==
------END PUBLIC KEY-----]], false),
+-----END PUBLIC KEY-----]],
     }
     local claims = {
       test = "test",
@@ -113,4 +197,46 @@ D5z2A7KPYXUgUP0jd5yLZ7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQ==
     if not decodedClaims then error(err) end
     assert.are.same(claims, decodedClaims)
   end)
+
+    it("does not throw an error when key is invalid in rs256", function()
+    local keys = {
+      private =
+[[-----BEGIN RSA PRIVATE KEY-----
+MIIBOwIBAAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/D5z2A7KPYXUgUP0jd5yL
+Z7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQJBAJYXWNmw7Cgbkk1+v3C0
+dyeqHYF0UD5vtHLxs/BWLPI2lZO0e6ixFNI4uIuatBox1Zbzt1TSy8T09Slt4tNL
+CAECIQD6PHDGtKXcI2wUSvh4y8y7XfvwlwRPU2AzWZ1zvOCbbQIhANzgMpUNOZL2
+vakju4sal1yZeXUWO8FurmsAyotAx9tBAiB2oQKh4PAkXZKWSDhlI9CqHtMaaq17
+Yb5geaKARNGCPQIgILYrh5ufzT4xtJ0QJ3fWtuYb8NVMIEeuGTbSyHDdqIECIQDZ
+3LNCyR2ykwetc6KqbQh3W4VkuatAQgMv5pNdFLrfmg==
+-----END RSA PRIVATE KEY-----]],
+      public =
+[[-----BEGIN PUBLIC KEY-----
+MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBANfnFz7xPmYVdJxZE7sQ5quh/XUzB5y/
+D5z2A7KPYXUgUP0jd5yLZ7+pVBcFSUm5AZXJLXH4jPVOXztcmiu4ta0CAwEAAQ==
+-----END PUBLIC KEY-----]],
+    }
+    local invalid_key = "a really invalid key"
+    local data = {
+      test = "test",
+    }
+    local token = jwt.encode(data, {alg = "RS256", keys = keys})
+    assert.has.no.error(function ()
+      local result, err = jwt.decode(token, {keys = {public = invalid_key }})
+      assert.is_nil(result)
+      assert.is_not_nil(err)
+    end)
+  end)
+
+  it("throws an error when failing to generate a signature", function()
+    local invalid_key = "a really invalid key"
+    local data = {
+      test = "test",
+    }
+    assert.has_error(function ()
+      local token, err = jwt.encode(data, {alg = "RS256", keys = { private = invalid_key }})
+      assert.is_nil(token)
+      assert.is_not_nil(err)
+    end)
+  end)
 end)

src/jwt/jws.lua

@@ -1,24 +1,45 @@
 local basexx  = require 'basexx'
 local json    = require 'cjson'
 json.encode_empty_table('array')
-local crypto  = require 'crypto'
+local digest  = require 'openssl.digest'
+local hmac    = require 'openssl.hmac'
+local pkey    = require 'openssl.pkey'
 
 local data    = {}
 
+local function tohex(s)
+  local result = ""
+  for i = 1, #s do
+    result = result..string.format("%.2x", string.byte(s, i))
+  end
+  return result
+end
+
 data.sign = {
-  ['HS256'] = function(data, key) return crypto.hmac.digest('sha256', data, key) end,
-  ['HS384'] = function(data, key) return crypto.hmac.digest('sha384', data, key) end,
-  ['HS512'] = function(data, key) return crypto.hmac.digest('sha512', data, key) end,
-  ['RS256'] = function(data, key) return crypto.sign("sha256", data, key) end,
+  ['HS256'] = function(data, key) return tohex(hmac.new(key, 'sha256'):final (data)) end,
+  ['HS384'] = function(data, key) return tohex(hmac.new(key, 'sha384'):final (data)) end,
+  ['HS512'] = function(data, key) return tohex(hmac.new(key, 'sha512'):final (data)) end,
+  ['RS256'] = function(data, key)
+    assert(type(key) == "string")
+    local ok, result = pcall(function()
+      return pkey.new(key):sign(digest.new('sha256'):update(data))
+    end)
+    if not ok then return nil, result end
+    return result
+  end,
 }
 
 data.verify = {
-  ['HS256'] = function(data, signature, key) return signature == crypto.hmac.digest('sha256', data, key) end,
-  ['HS384'] = function(data, signature, key) return signature == crypto.hmac.digest('sha384', data, key) end,
-  ['HS512'] = function(data, signature, key) return signature == crypto.hmac.digest('sha512', data, key) end,
+  ['HS256'] = function(data, signature, key) return signature == tohex(hmac.new (key, 'sha256'):final (data)) end,
+  ['HS384'] = function(data, signature, key) return signature == tohex(hmac.new (key, 'sha384'):final (data)) end,
+  ['HS512'] = function(data, signature, key) return signature == tohex(hmac.new (key, 'sha512'):final (data)) end,
   ['RS256'] = function(data, signature, key)
-    local pubkey = type(key) == "userdata" and key or crypto.pkey.from_pem(key)
-    return crypto.verify("sha256", data, signature, pubkey)
+    assert(type(key) == "string")
+    local ok, result = pcall(function()
+      return pkey.new(key):verify(signature, digest.new('sha256'):update(data))
+    end)
+    if not ok then return nil, result end
+    return result
   end,
 }