Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enter behavior when the next list item is done #45

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

gergesh
Copy link
Contributor

@gergesh gergesh commented Nov 20, 2020

Previously, if a list item was followed by a done item there was no
way to insert an additional one.

In the long term, I think the current behavior is still clunky and the one
employed by Keep (which moves all done items to a separate section)
is more intuitive (but perhaps best kept under a toggle).

Previously, if a list item was followed by a done item there was no
way to insert an additional item.
@OmGodse OmGodse closed this Nov 24, 2020
@OmGodse OmGodse reopened this Nov 24, 2020
@OmGodse OmGodse merged commit 677b200 into OmGodse:master Nov 24, 2020
@OmGodse
Copy link
Owner

OmGodse commented Nov 24, 2020

I think you're partially correct, the current behavior to do nothing when the next list item is done has to be changed.

However, I don't think that adding a list item if the next is done is the correct model. I'll modify it such that if the next list item is checked, the cursor would jump to the one after that and so on, until it encounters the end of the list, at which point, a new item would be inserted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants