Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Japanese Translation #65

Merged
merged 1 commit into from May 9, 2021
Merged

Created Japanese Translation #65

merged 1 commit into from May 9, 2021

Conversation

kat0h
Copy link
Contributor

@kat0h kat0h commented May 9, 2021

Hello, I translated this app into Japanese.
Thanks for your reply and caring (the csv file which you sent helps me).

I tried build the translated app and it runs normally.
Please check my changes.

Suggestion:
In japanese, this notation is not naturally.
I think this is better. (This notation has not changed in this commit)

not Natural: 日9 5月 2021
Natural : 2021 5月 9日

Screenshot_20210509_222551

--
kota kato (yes, this is my fullname)
peony.btn@gmail.com
github account: @KATO-K

@OmGodse OmGodse merged commit ae17acd into OmGodse:master May 9, 2021
@OmGodse
Copy link
Owner

OmGodse commented May 9, 2021

I'll look into the date formatting

@kat0h
Copy link
Contributor Author

kat0h commented May 9, 2021

Thank you

@kat0h
Copy link
Contributor Author

kat0h commented May 10, 2021

Sorry I made a mistake

This is an one of date format

Example:
English: (Mon 05/09 20201)
Japanese: 2021年 5月 29日 (月)
年 represents year
月 represents month
日 represents date
(月) represents days of the means (日,月,火,水,木,金,土,日) <=> (Sun, Mon...)

yyyy年M月d日 (E)

@OmGodse
Copy link
Owner

OmGodse commented May 17, 2021

Do you mean the following format yyyy MMM d EEE ? (2021 May 17 Mon)

@kat0h
Copy link
Contributor Author

kat0h commented May 17, 2021

Yes.

@kat0h
Copy link
Contributor Author

kat0h commented May 17, 2021

I made an experimental commit on the date format. (kat0h@b40ec83)
It's very dirty and doesn't inherit the existing format but works like this

English:
image
Japanese:
image

@OmGodse
Copy link
Owner

OmGodse commented May 18, 2021

Oh there's no need for that, I'm just going to hardcode the pattern for Japanese like this

val pattern = if (locale.language == Locale.JAPANESE.language) {
    "yyyy MMM d EEE"
} else "EEE d MMM yyyy"

@kat0h
Copy link
Contributor Author

kat0h commented May 19, 2021

Thank you very much. Looks very good.

Would you please use this pattern for better translation? and represent units
"yyyy年 MMM d日 (EEE)"
image
Sorry to keep asking, but I would appreciate it.

@OmGodse
Copy link
Owner

OmGodse commented May 19, 2021

Yeah sure 👍

@OmGodse
Copy link
Owner

OmGodse commented May 23, 2021

I've released the version with the Japanese translation and accredited you on CONTRIBUTORS.md

It'll take some time for it to appear on the Play Store and F Droid but you can get it now from the releases page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants