Package update #17
Merged
Package update #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added types for react and react-dom. Removed conflicting @jest/globals package Removed all babel, jest is using ts-jest.
It's no longer needed in tests.
Re-instaded babel needed for react-scripts to run. Removed transform from jest config and eslint.
SyntaxXeror
approved these changes
Mar 22, 2023
Slight modification to eslint.
|
Code Climate has analyzed commit cec4168 and detected 0 issues on this pull request. View more on Code Climate. |
Omarley7
added a commit
that referenced
this pull request
Mar 22, 2023
* Updated typescript and jest libaries. Added types for react and react-dom. Removed conflicting @jest/globals package Removed all babel, jest is using ts-jest. * Added import of jest-dom to jest.config.json. It's no longer needed in tests. * Build with no warnings and functional test. Re-instaded babel needed for react-scripts to run. Removed transform from jest config and eslint. * Remved jest/globals reference from tests. Slight modification to eslint.
Omarley7
added a commit
that referenced
this pull request
Mar 29, 2023
* Updated typescript and jest libaries. Added types for react and react-dom. Removed conflicting @jest/globals package Removed all babel, jest is using ts-jest. * Added import of jest-dom to jest.config.json. It's no longer needed in tests. * Build with no warnings and functional test. Re-instaded babel needed for react-scripts to run. Removed transform from jest config and eslint. * Remved jest/globals reference from tests. Slight modification to eslint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going though packages to check what is stopping the unit tests from working properly.