Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users without 4K permissions can request 4K movies #4957

Closed
Pyronious opened this issue Jun 11, 2023 · 4 comments · Fixed by #4982 or #4983
Closed

Users without 4K permissions can request 4K movies #4957

Pyronious opened this issue Jun 11, 2023 · 4 comments · Fixed by #4982 or #4983

Comments

@Pyronious
Copy link

Pyronious commented Jun 11, 2023

Describe the bug
Users who have the "Request 4K Movie" role disabled can request 4K movies.

To Reproduce
Steps to reproduce the behavior:

  1. Use a user account with "Request 4K Movie" role disabled
  2. Search for a movie
  3. From search results, click the "Request" banner at the bottom of the movie poster

Observed behavior:
A pop-up appears with choices for "Request" and "Request 4K"

Expected behavior:
Only the "Request" button should be available

Screenshots:
User does not have "Request 4K Movie" role enabled:
YZsxF4Njfo

User can see and interact with "Request 4K" button:
File

Example of requested 4K movie:
AIdsgWtyKh

Logs (Logs directory where Ombi is located)
There were no log entries on the date the request was made.

Desktop (please complete the following information):

  • OS: iOS (Safari)

Ombi Version (please complete the following information):

  • Version 4.39.1
  • Media Server Plex
  • Database Type: SQLite
@github-actions
Copy link

Hi!

Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.

Have you looked at the wiki yet? https://docs.ombi.app/

Before posting make sure you also read our FAQ.

Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.

If we need more information or there is some progress we tag the issue or update the tag and keep you updated.

Thanks!

Ombi Bot.

@sephrat
Copy link
Contributor

sephrat commented Jun 12, 2023

The "Request 4K" button is always displayed at the moment, regardless of the user's permission. However, the request should fail with a permission error and the user should see an error message if they're not allowed.

In your case, the request is still processed because the user has "auto approve" role, which bypasses the 4K request role.
I would agree with you that "auto approve" role should not grant "4K request" role. @tidusjar any thoughts?

@tidusjar
Copy link
Collaborator

Yeah you are probably right

@tws101
Copy link

tws101 commented Jun 14, 2023

Yes,

We need an Auto Approve 4K
as opposed to Auto Approve Movie (Doing both)

sephrat added a commit to sephrat/Ombi that referenced this issue Jul 14, 2023
Legacy "Auto Approve" role now only applies to non-4K requests
Fixes Ombi-app#4957
tidusjar pushed a commit that referenced this issue Jul 14, 2023
Legacy "Auto Approve" role now only applies to non-4K requests
Fixes #4957
tidusjar added a commit that referenced this issue Jul 14, 2023
Legacy "Auto Approve" role now only applies to non-4K requests
Fixes #4957

Co-authored-by: sephrat <34862846+sephrat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants