Implement Basic Mass Email Functionality #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also missing some unit tests, but that'll be done once I get all the other wanted features in... |
Magikarplvl4
changed the title
Magikarplvl4
changed the title
|
@SuperPotatoMen thanks! I was talking to @tidusjar about taking on more features soon as I'm using it for learning new tech. Angular 2x for entire UI will likely be my next move :-) |
|
Excellent. I'll take a look tonight. I'm excited about the prospect of using angular! |
|
Looks good dude! All Merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tidusjar
So this was my first stab and navigating around your codebase but I have gotten mass email working. It is currently rendered on Newletter tab in admin section. I plan on breaking it out when I add the features you mentioned for selective emailing of users. I have been working from a small 12" laptop screen since I travel during the week for work so I'll get to working on the additional features once home with more monitors. Just wanted to get what I had done out. I know the code's not the cleanest but NancyFX was kicking my but as i'm used to WebApi2.
Open feature request: #358