Breaking changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaults for captioned figure styles weren't really though of, and were different from captioned tables "just" for checking which was applied. In a real book, one expects more homogeneity by default.
Omikhleia
force-pushed
the
breaking-changes
branch
from
906db28
to
6290789
Compare
So packages inherit the styles mechanism without having to repeat the same code again and again. Breaking as it impacts how certain things are loaded in those classes, and when... And standard 'autodoc' breaks at generating the package documentation.
So our classes inherit the styles mechanism without having to repeat the same code again and again.
Omikhleia
force-pushed
the
breaking-changes
branch
from
cf4f32c
to
60ffa4c
Compare
That's a departure from SILE 0.14 with dirty hacks and a very opinionated breaking change. See in-code comments. It also introduces 'autodoc-resilient' as standard 'autodoc', besides the same opinionated changes, cannot work any longer with resilient classes and packages, as 'partial' loading of packages won't get the styles due to previous refactors.
This was referenced Feb 4, 2023
Omikhleia
added
bug
Stop being too cautious, we want them all in "resilient".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that change the output document:
Things that have deeper breaking aspects
Also update the dev rockspec to load all our module as dependencies. There are needed in the manual, and there's no point for me not to have them. The only interest to have them as separate modules is that some people may want to use them without the rest of the resilient stuff, but heh.