Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #9 #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixes #9 #21

wants to merge 2 commits into from

Conversation

rajvinder-kaur
Copy link

closes #9 added fun ui and ux improvements with confetti explosions on right answer and solved all the conflicts
guess1
guess2

@OmkarKirpan
Copy link
Owner

Hi @rajvinder-kaur,
Nice work on improving the UX of the project.
We have added dark mode also in the app. Could you update the PR and integrate those changes as well?

I ran the CI check and got the following error:

Cannot find module 'react-confetti-explosion' or its corresponding type declarations.

@rajvinder-kaur
Copy link
Author

uh in this design only the card will got to the dark mode not much of the design , so i suggest to not to integrate the dark mode . if you still wish to integrate , ill do it.

@OmkarKirpan
Copy link
Owner

Hi @rajvinder-kaur ,
Please go ahead refactor the code and update the test cases.
We can add dark mode later for the main card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve ux
2 participants