Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision Detection : Broad Phase algorithm #50

Merged
merged 2 commits into from Aug 24, 2017

Conversation

aesee
Copy link
Contributor

@aesee aesee commented Aug 23, 2017

Added simple algorithm of 2D Collision Detection and made test for it.
My first experience with open source, i'm sorry if something wrong.

@Tjstretchalot
Copy link
Contributor

Tjstretchalot commented Aug 23, 2017

I'm working on a geometry library as well, with some minor merge commits as this one (specifically __init__.py). Currently just got the specs for it (http://pygorithm-fork.readthedocs.io/en/latest/Geometry.html) but it wouldn't hurt to take some precautionary measures:

I think you should consider renaming the file to broad_phase.py or rect_broad_phase.py to be more specific, and rename Body to Rect, SimpleRect, Rectangle, or something of that sort. Body is typically more general than a rectangle.

As you might know, broad-phase collision detection typically requires some sort of grid for it to have practical application. I was considering making a quad-tree, but a spatial tree or R-tree would work as well.

EDIT: Don't take anything I say too seriously until OmkarPathak gets a chance to look at it 👍

@aesee
Copy link
Contributor Author

aesee commented Aug 23, 2017

Thanks for the comment!
I renamed file and class to proposed and made a new commit. It wasn't hard.
I think I can write another implementation of broad phase for quad-tree if it is needed.

@OmkarPathak OmkarPathak merged commit 3735894 into OmkarPathak:master Aug 24, 2017
@aesee aesee deleted the feature branch August 24, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants