Merge from branch #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
OmkarPathak
commented
Sep 8, 2017
OmkarPathak
commented
- Use matplotlib for images
- Skeleton for extrapolated intersection
- Begin tests for extrapolated intersection
- Test calculate_one_moving_and_one_stationary
- Create sample image using matplotlib
This problem is definitely difficult and common enough to warrant its own module, but it doesn't define any new classes. * docs/Geometry.rst - autodoc the new module * pygorithm/geometry/extrapolated_intersection.py - first skeleton * tests/test_geometry.py - skeleton tests for extrap. intr
This uses a lot of images because generating tests for these is hard. The image files are all very small (<5kb) so it shouldn't make downloading the repo significantly slower. This algorithm can be tricky to get right so I wanted to have a very exhaustive test suite. * pygorithm/geometry/extrapolated_intersection.py - add more helper functions * pygorithm/geometry/polygon2.py - fix fuzzing test sometimes failing * tests/test_geometry.py - add regression test for polygon, add tests for first two functions of extrapolated_intersection + imgs/test_geometry/test_extrapolated_intersection - images that help visualize what the tests are doing. the naming convention is explained in test_geometry.TestExtrapolatedIntersection docstring
Add tests and images for calculate_one_moving_and_one_stationary in extrapolated intersection. This is at the same rate of 16 tests per func (16 images and 16 .grf files) * pygorithm/geometry/extrapolated_intersection.py - change to invalid return values so the tests fail as expected * tests/test_geometry.py - add tests for an additional function + imgs/test_geometry/test_extrapolated_intersection/(many) - test imgs.
This is a sample of what the images look like using matplotlib instead of Graph. + imgs/test_geometry/test_extrapolated_intersection/ aa01_test_point_line_no_intr.py - matplotlib to generate: + imgs/test_geometry/test_extrapolated_intersection/out/ aa01_test_point_line_no_intr_2.png - matplotlib generated file
Replace all the graph files and generated images with matplotlib files and generated images. This is from @IanDoarns suggestion on #69. * imgs/test_geometry/test_extrapolated_intersection/(many) - replace with matplotlib files * tests/test_geometry.py - update documentation to remove references to Graph files (in favor of matplotlib)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.