Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx=20: wait two confirmations after payment before allowing a new sell o... #38

Merged
merged 1 commit into from
Jan 17, 2014

Conversation

marv-engine
Copy link

...ffer

dacoinminster pushed a commit that referenced this pull request Jan 17, 2014
Wait two confirmations after payment before allowing a new sell order
@dacoinminster dacoinminster merged commit f724579 into OmniLayer:master Jan 17, 2014
@dacoinminster
Copy link
Contributor

Perfect! Thanks.

@marv-engine
Copy link
Author

Happy to help.

@maran
Copy link
Contributor

maran commented Jan 18, 2014

I'm really confused about the fact that this got merged without any discussion from any of the other developers. Grazcoin suggested a cancel offer message which I think makes a lot more sense.

@ripper234
Copy link
Contributor

Agreed, we should change the spec so quickly without the devs having a
chance to review.

J.R?
On Jan 18, 2014 11:42 PM, "Maran" notifications@github.com wrote:

I'm really confused about the fact that this got merged without any
discussion from any of the other developers. Grazcoin suggestedhttps://bitcointalk.org/index.php?topic=292628.msg4578796#msg4578796a cancel offer message which I think makes a lot more sense.


Reply to this email directly or view it on GitHubhttps://github.com//pull/38#issuecomment-32693976
.

@dacoinminster
Copy link
Contributor

Apologies for jumping the gun on this guys! I was worried people would get bogged down waiting for a decision on this :)

I'm very happy to accept a pull request adding a cancel command instead. Is somebody available to jump on that task? I want to avoid hearing "I haven't made much progress because I'm waiting on a decision about issue X." :)

Also posted here: https://bitcointalk.org/index.php?topic=292628.msg4623164#msg4623164

@maran
Copy link
Contributor

maran commented Jan 20, 2014

I've added #39 (and a variation #40). Please vote with your +1 and -1's :)

@ripper234
Copy link
Contributor

Is this still a candidate, or can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants