-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update benchmarks and provide configs for reproducing results #236
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #236 +/- ##
==========================================
- Coverage 93.55% 93.50% -0.06%
==========================================
Files 134 134
Lines 6904 6904
==========================================
- Hits 6459 6455 -4
- Misses 445 449 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
||
ep_ret += rew.item() | ||
ep_cost += (cost_criteria**length) * cost.item() | ||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can consider wrapper env using simmer
and saute
adapter directly, It can simplify the process of evaluating and show the power of Adapter mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great but, if do that, model-based evaluation must be rewritten. I think we can provide this feature in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some issues with the document, but it has improved significantly compared to the previous version. Let's first approve this PR, and then we can continue working on further refinements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
saute
,simmer
,early mdp
andpid-lagrangian
.You can see in this page to get a direct view: https://github.com/Gaiejj/omnisafe_zjy/tree/dev-readme/benchmarks
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)