Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update benchmarks and provide configs for reproducing results #236

Merged
merged 47 commits into from
May 19, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented May 12, 2023

Description

  • Update on-policy benchmarks, including saute, simmer, early mdp and pid-lagrangian.
  • Update off-policy lagrangian benchmarks.
  • Refactor the benchmarks training curves and tables of on-policy, off-policy, model-based algorithms.
  • Update configs, entrance file and evaluator to reproduce those public result.

You can see in this page to get a direct view: https://github.com/Gaiejj/omnisafe_zjy/tree/dev-readme/benchmarks

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj changed the base branch from main to dev May 12, 2023 13:12
@Gaiejj Gaiejj added documentation Improvements or additions to documentation enhancement New feature or request performance: metrics formance issue about metrics labels May 12, 2023
@Gaiejj Gaiejj changed the title docs: update omnisafe benchmarks feat: update benchmarks and provide configs for reproducing results May 12, 2023
@Gaiejj Gaiejj requested a review from XuehaiPan as a code owner May 12, 2023 13:24
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #236 (481f98c) into dev (60b7ea7) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 481f98c differs from pull request most recent head 7197e3b. Consider uploading reports for the commit 7197e3b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #236      +/-   ##
==========================================
- Coverage   93.55%   93.50%   -0.06%     
==========================================
  Files         134      134              
  Lines        6904     6904              
==========================================
- Hits         6459     6455       -4     
- Misses        445      449       +4     
Impacted Files Coverage Δ
omnisafe/utils/command_app.py 84.21% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

benchmarks/README.md Outdated Show resolved Hide resolved

ep_ret += rew.item()
ep_cost += (cost_criteria**length) * cost.item()
if (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can consider wrapper env using simmer and saute adapter directly, It can simplify the process of evaluating and show the power of Adapter mechanism.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great but, if do that, model-based evaluation must be rewritten. I think we can provide this feature in the future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@zmsn-2077 zmsn-2077 requested a review from muchvo May 17, 2023 19:46
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues with the document, but it has improved significantly compared to the previous version. Let's first approve this PR, and then we can continue working on further refinements.

@Gaiejj Gaiejj requested a review from zmsn-2077 May 18, 2023 15:24
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 3799d6d into PKU-Alignment:dev May 19, 2023
4 checks passed
@Gaiejj Gaiejj deleted the dev-readme branch May 19, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request performance: metrics formance issue about metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants