Add support for strongly typed data to be attached to */resolve #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
force-pushed
the
feature/resolve
branch
from
e21f85a
to
05be685
Compare
…pletion items, and document links. Adds support for multiple codelens, completion and document link handers for each text document.
david-driscoll
force-pushed
the
feature/resolve
branch
from
6c56cc0
to
9132bb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 62.12% 60.89% -1.24%
==========================================
Files 383 388 +5
Lines 11483 11720 +237
Branches 1361 1327 -34
==========================================
+ Hits 7134 7137 +3
- Misses 3782 4105 +323
+ Partials 567 478 -89
Continue to review full report at Codecov.
|
|
#269 superseeds this one, as it has fewer breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial stab at adding support for strongly typed data to be attached to codelens, completion items, and document links.
Adds support for multiple codelens, completion and document link handlers for each text document.
What this means is that you can have multiple codelens (and completion/document link) handlers for a document selector.
You might have a codelens handler that returns test lenses (and sets up data specific to text lenses). You could then have another handler that returns code lens for references, with a different data element. These will then be automatically merged for you by the server, and resolve requests will be routed to the correct handler.