Custom handlers not override built in handlers correctly

[david-driscoll]

• Fixed a bug in configuration (configuration values were case-sensitive).
• Added unit tests demonstrating Configuration.Binder, and Options usages

[codecov]

Codecov Report

Merging #392 into master will increase coverage by 0.00%.
The diff coverage is 68.85%.

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   75.83%   75.84%           
=======================================
  Files         561      561           
  Lines       13511    13536   +25     
  Branches     1247     1247           
=======================================
+ Hits        10246    10266   +20     
- Misses       3265     3270    +5     

Impacted Files	Coverage Δ
src/Client/LanguageClientOptions.cs	35.55% <0.00%> (ø)
...nRpc.Generators/GenerateHandlerMethodsGenerator.cs	84.24% <ø> (ø)
src/Protocol/LanguageProtocolDelegatingHandlers.cs	40.83% <0.00%> (-0.74%)	⬇️
...otocol/Workspace/IDidChangeConfigurationHandler.cs	0.00% <0.00%> (ø)
...col/Workspace/IDidChangeWorkspaceFoldersHandler.cs	0.00% <ø> (ø)
src/Server/DefaultLanguageServerFacade.cs	82.35% <0.00%> (ø)
src/Server/LanguageServerOptions.cs	23.52% <0.00%> (ø)
...sonRpc/JsonRpcServerServiceCollectionExtensions.cs	88.81% <72.00%> (-4.53%)	⬇️
...lient/LanguageClientServiceCollectionExtensions.cs	96.93% <100.00%> (ø)
...er/Configuration/DidChangeConfigurationProvider.cs	87.91% <100.00%> (+0.67%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b88655...ca564c0. Read the comment docs.

[ajaybhargavb]

I just tried this out. The didChangeConfiguration requests are coming through to the server now yay! However, I noticed that the response received by the server for workspace/configuration requests aren't correct. No matter what setting I set on the client, the result from this request is always the default value for each property. Calling vscode.workspace.getConfiguration() on the client returns the correct values so this isn't an issue with the client.

Another thing I noticed after upgrading to your latest commit is that I keep seeing a bunch of these exceptions. They weren't happening before afaik,

[ajaybhargavb]

Why was this deleted?

[david-driscoll]

There was a build issue, I mainly had it in there for local development (since I have the .net 5 installed) but it isn't strictly needed for CI.

[ajaybhargavb]

I see. I asked because when I tried to build locally with a .net 5 sdk, it failed. I had to pin it to 3.1.402 to make it work.

[david-driscoll]

I worked with @ajaybhargavb and I think we solved his underlying problem, and it looks like there are no more changes required. however I'll wait until I hear back if any other problems popped up.

[ajaybhargavb]

LGTM. I tested it out and looks like this fixed the issue. Thanks @david-driscoll!