Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings and bump minor versions #760

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Conversation

david-driscoll
Copy link
Member

Updated to latest minor versions of system.reactive, collections.immutable and nerdbank.streams

@david-driscoll david-driscoll added the chore Just keeping things neat and tidy label Feb 22, 2022
@github-actions github-actions bot added this to the v0.19.6 milestone Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #760 (7c1311d) into master (aacb0ba) will decrease coverage by 0.86%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   73.21%   72.34%   -0.87%     
==========================================
  Files         254      254              
  Lines       12554    12820     +266     
  Branches      807      805       -2     
==========================================
+ Hits         9191     9275      +84     
- Misses       3363     3545     +182     
Impacted Files Coverage Δ
src/Dap.Client/DebugAdapterClientOptions.cs 6.25% <0.00%> (-10.42%) ⬇️
...erators/AssemblyCapabilityKeyAttributeGenerator.cs 1.31% <0.00%> (-0.25%) ⬇️
...ators/AssemblyJsonRpcHandlersAttributeGenerator.cs 2.77% <0.00%> (-0.21%) ⬇️
src/JsonRpc/DefaultJsonRpcServerFacade.cs 0.00% <0.00%> (ø)
src/JsonRpc/NoopResponseRouter.cs 0.00% <0.00%> (ø)
src/Protocol.Proposals/ProposedExtensions.cs 100.00% <ø> (ø)
...l.Proposals/Serialization/ProposedLspSerializer.cs 93.33% <ø> (ø)
...rc/Server/Pipelines/SemanticTokensDeltaPipeline.cs 100.00% <ø> (ø)
...nRpc/Serialization/Converters/RpcErrorConverter.cs 78.12% <16.66%> (-14.98%) ⬇️
src/JsonRpc/IActivityTracingStrategy.cs 8.33% <21.15%> (+0.20%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aacb0ba...7c1311d. Read the comment docs.

@david-driscoll david-driscoll merged commit 7e0eefd into master Apr 28, 2022
@david-driscoll david-driscoll deleted the fixup/warnings branch April 28, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Just keeping things neat and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant