Fixed broken Mocha test for aspnet:Config sub-generator

[scottaddie]

When running the npm test command, the Mocha test for the aspnet:Config sub-generator was broken and returned an error message. I tracked this error down and found that it was thrown from the yeoman-environment module's lib/environment.js file. Because there's a file named config.js in the root of the project, that file was being detected before the Config sub-generator. Since config.js isn't a generator, an error was thrown stating that the aspnet:Config sub-generator wasn't installed.

To fix this problem, I renamed the sub-generator to aspnet:ConfigJson. This change does a couple things:

1. Makes the name consistent with other JSON file sub-generators, such as aspnet:BowerJson and aspnet:PackageJson
2. Makes the sub-generator unique, which avoids file name collisions

Since I was fixing a problem with one of the unit tests, I updated the Mocha and Chai dependencies as well.

[peterblazejewicz]

1. what was that error? I always run tests when reviewing PRs
2. why rewriting all this, instead of renaming 'config.js' added as namespace-finding util module?
3. what was that problem with deps requiring update? (we won't be able to revert deps update easily)
   Thanks!
4. edit: I agree about some naming problems - but we don't know what are naming internals for MS template items yet (they still didn't released them)

[spboyer]

@peterblazejewicz agreed, I am not getting any errors on aspnet:Config, not sure this PR is needed.

[scottaddie]

@peterblazejewicz To answer your questions:

1. Here's what I see when running npm test. I got the same results on 3 different machines. All 3 were running Node v4.2.0 with npm 3.3.8.
   
   
2. I suppose I could've done something like that, but I felt that this change would enforce consistency. The other JSON file sub-generators I saw in the project were suffixed with "JSON".
3. No problem at all with the Mocha and Chai dependencies. I just figured that I was in the code that used them, so this was the perfect opportunity to bring things up-to-date.

My question to @spboyer and @peterblazejewicz would be, what's different with your setups that you're not encountering this problem? Specifically, which versions of Node and npm are you using?

[peterblazejewicz]

what's different with your setups that you're not encountering this problem? Specifically, which versions of Node and npm are you using?

OS X/Node 0.12.* because of this: #351, NPM 2.11.*
I'll try at work tomorrow on Windows OS

[spboyer]

I'm running node 0.10.38 or 0.12.x and npm 2.14.x on OSX, and the same versions in WIN 10. I have not done any testing on npm 3.x or node 4. Before rc1 we need to put this into the test cycle to support node 4.x

[david-driscoll]

I get the same error on Windows I just wound up ignoring it, because things
pass just fine on Travis.
On Thu, Oct 15, 2015 at 5:10 PM Shayne Boyer notifications@github.com
wrote:

I'm running node 0.10.38 or 0.12.x and npm 2.14.x on OSX, and the same
versions in WIN 10. I have not done any testing on npm 3.x or node 4.
Before rc1 we need to put this into the test cycle to support node 4.x

—
Reply to this email directly or view it on GitHub
#420 (comment)
.

Thanks,
David

[scottaddie]

I saw this same error on Windows 7, 8.1, and 10.

[spboyer]

I would suggest installing nvm and running node 0.10.x or 0.12.x with npm 3, this appears to be a compatibility issue with node 4

[scottaddie]

In case anyone is interested, here's where the error is thrown:

Notice that the resolved property of the Generator object has the path to the project root's config.js file.

[peterblazejewicz]

I haven't managed to recreate this on OS X, so this could be Windows only issue (see @david-driscoll comment above).
@scottaddie
Scott, if still not convinced to rename only config.js, could you consider to splitting PR into separate one, so update to deps is in different PR?

[scottaddie]

@peterblazejewicz I messed something up in my local repo while trying to revert some changes. I'm going to close this PR and resubmit this as 2 PRs: 1 for the new deps and 1 for the config.js name change.