This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
Show generic error and exit on network error. Fixes #55 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
spboyer
added a commit
that referenced
this pull request
Feb 3, 2015
Show generic error and exit on network error. Fixes #55
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces basic error handling for Yeoman
remotefetch future used in application which fails silently on network error.Instead of seeing this:
info ... Fetching https://github.com/OmniSharp/generator-aspnet/archive/release.tar.gz ... info This might take a few moments /Users/piotrblazejewicz/.cache/yeoman Your project is now created, you can use the following commands to get going kpm restore kpm build k run for console projects k kestrel or k webfor web projectsthe process will now spill error and exit process:
This is standard solution used in Yeoman projects using remote repository fetching, e.g.:
https://github.com/yeoman/generator-mobile/blob/29c5dbcb947f219c82eca200514788218bf26603/app/index.js#L84-L87
Thanks!