Avoid white status bar items to ensure contrast

[Tyriar]

Fixes #4384

I didn't test this but expect it to work and be a low risk change.

[dnfadmin]

All CLA requirements met.

[codecov]

Codecov Report

Merging #4385 (11ea57d) into master (5270351) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4385      +/-   ##
==========================================
- Coverage   68.77%   68.71%   -0.06%     
==========================================
  Files         108      108              
  Lines        4307     4306       -1     
  Branches      747      747              
==========================================
- Hits         2962     2959       -3     
- Misses       1139     1142       +3     
+ Partials      206      205       -1     

Flag	Coverage Δ
integration	53.49% <100.00%> (-0.06%)	⬇️
unit	85.81% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/observers/OmnisharpStatusBarObserver.ts	100.00% <100.00%> (ø)
src/features/semanticTokensProvider.ts	82.00% <0.00%> (-4.00%)	⬇️
src/features/codeLensProvider.ts	54.65% <0.00%> (-1.17%)	⬇️
src/features/diagnosticsProvider.ts	82.40% <0.00%> (+0.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5270351...11ea57d. Read the comment docs.

[JoeRobich]

Thanks for this fix! This will have the status bar icon use the StatusBar.Foreground color which is appropriate.