Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to to exclude custom symbols from codelens #4418

Merged

Conversation

@leo-labs
Copy link
Contributor

@leo-labs leo-labs commented Mar 3, 2021

Fixes #4335

To fix these performance problem I have added an option to exclude additional symbols from codelens which can be used like this in settings.json:

"csharp.referencesCodeLens.filteredSymbols": [
        "MyMethod1",
        "MyMethod2"
    ],
@dnfadmin
Copy link

@dnfadmin dnfadmin commented Mar 3, 2021

CLA assistant check
All CLA requirements met.

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Mar 26, 2021

Thanks for this change! You will also need to define the option in the project.json . I know a lot of people will be happy for this change to get in.

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented May 3, 2021

Thanks @leo-labs!

@JoeRobich JoeRobich merged commit 76182f2 into OmniSharp:master May 3, 2021
3 checks passed
3 checks passed
@github-actions
build
Details
license/cla All CLA requirements met.
Details
security/snyk (david-driscoll) 1 security test has passed
Details
@leo-labs
Copy link
Contributor Author

@leo-labs leo-labs commented May 17, 2021

@JoeRobich Any chance we can get a release with these changes?

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented May 17, 2021

Any chance we can get a release with these changes?

I agree it is time for a new release. I'll start the work to get one together.

@leo-labs
Copy link
Contributor Author

@leo-labs leo-labs commented May 19, 2021

Thanks @JoeRobich for doing a release. Any reason why v1.23.12 is marked as pre-release an not available in the visual studio code marketplace?

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented May 19, 2021

Any reason why v1.23.12 is marked as pre-release an not available in the visual studio code marketplace?

It is being validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants