Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the global Mono check to the correct place #4492

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

filipw
Copy link
Contributor

@filipw filipw commented Apr 9, 2021

fixes #4489

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #4492 (78167cd) into master (6ee8745) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4492   +/-   ##
=======================================
  Coverage   68.69%   68.69%           
=======================================
  Files         109      109           
  Lines        4287     4287           
  Branches      742      742           
=======================================
  Hits         2945     2945           
- Misses       1140     1141    +1     
+ Partials      202      201    -1     
Flag Coverage Δ
integration 52.26% <0.00%> (ø)
unit 85.81% <20.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/omnisharp/OmniSharpMonoResolver.ts 84.00% <20.00%> (ø)
src/features/semanticTokensProvider.ts 82.00% <0.00%> (-4.00%) ⬇️
src/features/diagnosticsProvider.ts 77.77% <0.00%> (+0.92%) ⬆️
src/features/codeLensProvider.ts 54.54% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85228...78167cd. Read the comment docs.

@JoeRobich JoeRobich merged commit 84669d1 into master Apr 9, 2021
@JoeRobich JoeRobich deleted the bugfix/mono branch October 18, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants