Support using .NET 6 OmniSharp #4926
Conversation
Adds an option for using the .NET 6 version of OmniSharp, and supports getting it and the right executables on all platforms.
package.json
Outdated
| "integrity": "43D6B18F390B8ED92231044E87413831E565E9AB5938223B19CA97B3628DDDF4" | ||
| }, | ||
| { | ||
| "id": "OmniSharp", | ||
| "description": "OmniSharp for Linux (x86)", | ||
| "description": "OmniSharp for OSX (.NET 6)", |
There was a problem hiding this comment.
I think you are missing a split into x64 and arm64 here
There was a problem hiding this comment.
good catch. We don't have one currently, because we install the x64 for both architectures. Since the net6 builds are currently being built as self-contained this might cause issues. Certainly wouldn't perform as well.
There was a problem hiding this comment.
I added profiles for the other platforms. @filipw, can you give it a try on Mac?
There was a problem hiding this comment.
I went through this list and updated our profiles based on it, from the beta83 publish of omnisharp-roslyn:
1.37.18-beta.83/omnisharp-win-x86.zip
1.37.18-beta.83/omnisharp-win-x86-net6.0.zip
1.37.18-beta.83/omnisharp-win-x64.zip
1.37.18-beta.83/omnisharp-win-x64-net6.0.zip
1.37.18-beta.83/omnisharp-win-arm64.zip
1.37.18-beta.83/omnisharp-win-arm64-net6.0.zip
1.37.18-beta.83/omnisharp-osx.zip
1.37.18-beta.83/omnisharp-osx.tar.gz
1.37.18-beta.83/omnisharp-osx-x64-net6.0.zip
1.37.18-beta.83/omnisharp-osx-x64-net6.0.tar.gz
1.37.18-beta.83/omnisharp-osx-arm64-net6.0.zip
1.37.18-beta.83/omnisharp-osx-arm64-net6.0.tar.gz
1.37.18-beta.83/omnisharp-mono.zip
1.37.18-beta.83/omnisharp-mono.tar.gz
1.37.18-beta.83/omnisharp-linux-x86.zip
1.37.18-beta.83/omnisharp-linux-x86.tar.gz
1.37.18-beta.83/omnisharp-linux-x64.zip
1.37.18-beta.83/omnisharp-linux-x64.tar.gz
1.37.18-beta.83/omnisharp-linux-x64-net6.0.zip
1.37.18-beta.83/omnisharp-linux-x64-net6.0.tar.gz
1.37.18-beta.83/omnisharp-linux-arm64.zip
1.37.18-beta.83/omnisharp-linux-arm64.tar.gz
| @@ -5,48 +5,56 @@ | |||
|
|
|||
| import { Package } from "../packageManager/Package"; | |||
|
|
|||
| export function GetPackagesFromVersion(version: string, runTimeDependencies: Package[], serverUrl: string, installPath: string): Package[] { | |||
| export const modernNetVersion = "6.0"; | |||
There was a problem hiding this comment.
Filed OmniSharp/omnisharp-roslyn#2294 to track removing the need for this constant.
…arp.exe`. Support setting the path to the `dotnet` executable for this.
|
@333fred, @JoeRobich, @filipw just configured Omnisharp with the useModernNet. Whoa, performance is much, much better. In some larger projects I was barely able to type sometimes. It's really snappy with .Net 6 on my iMac. Just wanted to let you know this, because it might solve a lot of open performance issues for a lot of people. |
Adds an option for using the .NET 6 version of OmniSharp, and supports getting it and the right executables on all platforms.
Closes #4843