Quote arguments containing spaces when launching OmniSharp. #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Apr 4, 2022
|
nodejs/node#7367 (comment) Recommends using cross-spawn package which implements this correctly without the need to manually escape, or at least that is what they say. Might be worth a try. |
JoeRobich
force-pushed
the
quote-workspace-path
branch
from
c21c4d1
to
114ca49
Compare
|
Updated to use cross-spawn package. Need to verify Windows launch behavior. |
333fred
approved these changes
Apr 5, 2022
|
Confirmed works with spaces in workspace path on windows with both "omnisharp.useModernNet": "true" & "false" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5150
Tested locally with a Folder name containing a space. Failed to launch prior to this change and opens as expected with the change.