Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mining_Drones_Remastered support #426

Closed
wants to merge 1 commit into from
Closed

Conversation

AivanF
Copy link

@AivanF AivanF commented Oct 11, 2023

OmniFluid will now support almost any fork of Mining_Drones, not changing their required fluid. Requested in MD2R discussions.

OmniFluid will now support almost any fork of Mining_Drones, not changing their required fluid.
@Cereal-Sam
Copy link
Contributor

Cereal-Sam commented Oct 11, 2023

Thanks for raising the issue and the PR.
I rather want to add your fork to the mod name check to avoid it looping through all recipes and doing the string checks even with modsets that don't include mining drones. The other forks seem outdated/rarely used to me.

Regarding compat, you might also want to look at this, since you seem to have forked before that:
Klonan/Mining_Drones#20

@AivanF
Copy link
Author

AivanF commented Oct 12, 2023

@Cereal-Sam by the way, I'd suggest to use a global variable like in Earendel mods, so that ignorance can be easily added by your OmniFluid or other mods themselves, like this:

omnifluid_ignore_recipe_categories = omnifluid_ignore_recipe_categories or {}
table.insert(omnifluid_ignore_recipe_categories, "mining_depot")

This might be helpful in many cases, e.g: some players request me to make a mod with different levels/grades of drones and depots, they will probably have different recipe categories, and it's easier to support on the side of my mod rather than OmniFluid.

And yeah, I'll add that hidden dependency 👌

@Cereal-Sam
Copy link
Contributor

@Cereal-Sam by the way, I'd suggest to use a global variable like in Earendel mods, so that ignorance can be easily added by your OmniFluid or other mods themselves, like this:

omnifluid_ignore_recipe_categories = omnifluid_ignore_recipe_categories or {}
table.insert(omnifluid_ignore_recipe_categories, "mining_depot")

This might be helpful in many cases, e.g: some players request me to make a mod with different levels/grades of drones and depots, they will probably have different recipe categories, and it's easier to support on the side of my mod rather than OmniFluid.

And yeah, I'll add that hidden dependency 👌

The compat functions are globals for exactly this reason. You can call them in your mod,
With global tables there is always the risk that someone messes something up. The function is easier to use for external mods and reduces the risk for incorrect entries on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants