Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SongProvider as a singleton #32

Closed
OmriLevy888 opened this issue May 1, 2022 · 0 comments
Closed

SongProvider as a singleton #32

OmriLevy888 opened this issue May 1, 2022 · 0 comments
Assignees
@OmriLevy888
Projects
song-tinder

Comments

@OmriLevy888
Copy link
Owner

After doing #24, it's getting really cumbersome to pass objects that implement the logic though many layers of widgets.
It might be wise to change SongProvider to be a singleton where its state is modified over the lifetime of the app.
This would simplify many widget constructors and make them const again!
@OmriLevy888 OmriLevy888 self-assigned this May 1, 2022
@OmriLevy888 OmriLevy888 added this to To do in song-tinder May 1, 2022
OmriLevy888 added a commit that referenced this issue May 4, 2022
@OmriLevy888
[#32] Song provider is now a singleton
ae372b0
@OmriLevy888 OmriLevy888 moved this from To do to Done in song-tinder May 4, 2022
OmriLevy888 added a commit that referenced this issue May 4, 2022
@OmriLevy888
Merge pull request #33 from OmriLevy888/SongProvider-as-a-singleton
cea14e2 
[#32] Song provider is now a singleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmriLevy888 OmriLevy888

Labels
None yet
Projects
song-tinder
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OmriLevy888