Slightly better method for recording; TimeSeries only needs to set a … #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post-pull request back merge
…flag for when it has written to file, and record will see the flag and stop the respective stream. There is still an issue with this, since split_append will add the trailing samples from the chunk after writing to file; the correct duration will be in the file but may be sllightly offset in memory. Not sure how to fix this yet.
Bringing up to date with master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…flag for when it has written to file, and record will see the flag and stop the respective stream. There is still an issue with this, since split_append will add the trailing samples from the chunk after writing to file; the correct duration will be in the file but may be sllightly offset in memory. Not sure how to fix this yet.