Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Projects #34

Open
3 tasks
JeremyCaney opened this issue Mar 5, 2021 · 0 comments
Open
3 tasks

Separate Projects #34

JeremyCaney opened this issue Mar 5, 2021 · 0 comments
Labels
Area: Mapping Relates to one of the `ITopicMappingService` interfaces or implementations. Area: Packages Relates to packaging the library as a NuGet package. Status 0: Discussion Needs further evaluation of requirements and prioritization. Type: Improvement Improves the functionality or interface of an existing feature.
Projects
.NET 5.x Version

Comments

@JeremyCaney
Copy link
Member

Currently, a number of implementations which aren’t required by the core OnTopic library are included in the OnTopic project. We should consider migrating these to separate projects (and, thus, packages) within the same repository, similar to e.g., SqlTopicRepository.

Obviously, the interfaces, base classes, and any shared classes would remain in the OnTopic project.

Candidates

  • (Cached)TopicMappingService
  • (Cached)HierarchicalTopicMappingService
  • ReverseTopicMappingService

Positively, this would better separate ancillary libraries. Negatively, it would increase the number of packages, even though most would be needed by typical projects, and it’s unlikely that we’d end up with alternate implementations that might need to be swapped out.
@JeremyCaney JeremyCaney created this issue from a note in .NET 5.x Version (Deferred) Mar 5, 2021
@JeremyCaney JeremyCaney added Area: Mapping Relates to one of the `ITopicMappingService` interfaces or implementations. Area: Packages Relates to packaging the library as a NuGet package. Status 0: Discussion Needs further evaluation of requirements and prioritization. Type: Improvement Improves the functionality or interface of an existing feature. labels Mar 5, 2021
JeremyCaney added a commit that referenced this issue Jan 6, 2022
@JeremyCaney
Establish Mapping filter, section
a484cfd 
The `Mapping.yml` filter includes the `OnTopic.Mapping` namespaces under a new `/Mapping` folder. As part of this, the `OnTopic.Mapping` namespaces are also removed from the `Base` filter (3a54aca). This is useful as the mapping libraries are largely independent of the base libraries—so much so that they're a candidate for separation in OnTopic 6.x (#34)—and are also a major source of complexity. Having them in their own section makes intuitive sense from the implementer's perspective.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Mapping Relates to one of the `ITopicMappingService` interfaces or implementations. Area: Packages Relates to packaging the library as a NuGet package. Status 0: Discussion Needs further evaluation of requirements and prioritization. Type: Improvement Improves the functionality or interface of an existing feature.
Projects
No open projects
.NET 5.x Version
  
Deferred
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyCaney