Merge pull request lmc-eu#290 from OndraM/feature/github-releases

Download Selenium server releases from GitHub

.appveyor.yml

@@ -21,8 +21,7 @@ init:
 install:
   - IF EXIST c:\tools\php (SET PHP=0)
   - IF %PHP%==1 cinst -y OpenSSL.Light
- # TODO: remove -version and use the latest PHP (after Steward has PHP 8.0 support)
-  - IF %PHP%==1 cinst -y php -version 7.4.15 --params "/InstallDir:C:\tools\php" # we could use -version to specify exact version, but we rather use the latest available
+  - IF %PHP%==1 cinst -y php --params "/InstallDir:C:\tools\php" # we do not use -version to specify exact version, but we rather use the latest available
   - cd C:\tools\php
   - IF %PHP%==1 copy php.ini-production php.ini /Y
   - IF %PHP%==1 echo extension_dir=ext >> php.ini
@@ -37,6 +36,6 @@ install:
 
 test_script:
   - cd %APPVEYOR_BUILD_FOLDER%\src-tests\
-  - ..\vendor\bin\phpunit --colors=always --exclude-group integration
+  - php ..\vendor\bin\phpunit --colors=always --exclude-group integration
 
 build: false # disable build step (we only run tests)

.github/workflows/tests.yaml

@@ -54,7 +54,7 @@ jobs:
 
     strategy:
       matrix:
-        selenium-version: ['3.141.59', '4.0.0-beta-2']
+        selenium-version: ['3.141.59', '4.1.0']
 
     name: Integration tests (Selenium ${{ matrix.selenium-version }})
 

CHANGELOG.md

@@ -3,6 +3,9 @@
 <!-- There is always Unreleased section on the top. Subsections (Added, Changed, Fixed, Removed) should be added as needed. -->
 
 ## Unreleased
+### Changed
+- Download Selenium server releases from GitHub (see [announcement](https://www.selenium.dev/blog/2021/downloads-moving-to-github-releases/)).
+
 ### Removed
 - `resolveRequiredCapabilities()` method from `CustomCapabilitiesResolverInterface`, as this feature is not fully used in php-webdriver anyway.
 

src-tests/AssertDownloadableTrait.php

@@ -8,9 +8,8 @@ protected function assertIsDownloadable(string $url): void
     {
         $context = stream_context_create(['http' => ['method' => 'HEAD', 'ignore_errors' => true]]);
         $fd = fopen($url, 'rb', false, $context);
-        $responseCode = $http_response_header[0];
         fclose($fd);
 
-        $this->assertStringContainsString('200 OK', $responseCode, 'Error downloading from "' . $url . '"');
+        $this->assertContains('HTTP/1.1 200 OK', $http_response_header, 'Error downloading from "' . $url . '"');
     }
 }

src-tests/Selenium/DownloaderTest.php

@@ -49,7 +49,7 @@ public function testShouldAssembleUrlToDownload(string $version, string $expecte
         $downloader = new Downloader(__DIR__ . '/Fixtures', Version::createFromString($version));
 
         $this->assertSame(
-            'https://selenium-release.storage.googleapis.com' . $expectedPath,
+            'https://github.com/SeleniumHQ/selenium/releases/download/' . $expectedPath,
             $downloader->getFileUrl()
         );
     }
@@ -60,12 +60,12 @@ public function testShouldAssembleUrlToDownload(string $version, string $expecte
     public function provideVersions(): array
     {
         return [
-            ['2.53.0', '/2.53/selenium-server-standalone-2.53.0.jar'],
-            ['2.53.1', '/2.53/selenium-server-standalone-2.53.1.jar'],
-            ['3.0.0-beta2', '/3.0-beta2/selenium-server-standalone-3.0.0-beta2.jar'],
-            ['3.0.0', '/3.0/selenium-server-standalone-3.0.0.jar'],
-            ['4.0.0-beta-1', '/4.0-beta-1/selenium-server-4.0.0-beta-1.jar'],
-            ['4.0.0', '/4.0/selenium-server-4.0.0.jar'],
+            ['2.53.0', 'selenium-2.53.0/selenium-server-standalone-2.53.0.jar'],
+            ['2.53.1', 'selenium-2.53.1/selenium-server-standalone-2.53.1.jar'],
+            ['3.0.0', 'selenium-3.0.0/selenium-server-standalone-3.0.0.jar'],
+            ['3.141.59', 'selenium-3.141.59/selenium-server-standalone-3.141.59.jar'],
+            ['4.0.0-beta-4', 'selenium-4.0.0-beta-4/selenium-server-4.0.0-beta-4.jar'],
+            ['4.0.0', 'selenium-4.0.0/selenium-server-4.0.0.jar'],
         ];
     }
 
@@ -94,7 +94,7 @@ public function testShouldStoreDownloadedFileToExpectedLocation(): void
         $expectedFile = __DIR__ . '/Fixtures/selenium-server-standalone-1.33.7.jar';
         $this->assertFileNotExists($expectedFile, 'File already exists, though it should be created only by the test');
 
-        $this->mockGetHeadersToReturnHeader('HTTP/1.0 200 OK');
+        $this->mockGetHeadersToReturnHeader('HTTP/1.1 200 OK');
 
         $this->assertEquals(9, $downloader->download());
         $this->assertFileExists($expectedFile);
@@ -141,7 +141,7 @@ public function testShouldCreateTargetDirectoryIfNotExists(): void
             ->method('getFileUrl')
             ->willReturn(__DIR__ . '/Fixtures/dummy-file.jar');
 
-        $this->mockGetHeadersToReturnHeader('HTTP/1.0 200 OK');
+        $this->mockGetHeadersToReturnHeader('HTTP/1.1 200 OK');
 
         $downloader->download();
 

src-tests/Selenium/Fixtures/releases-response-missing.json

@@ -0,0 +1 @@
+{}