Added index files to import from and added test script so Grunt doesn't have to be installed globally #17
Conversation
|
@Jahans3 pls fix js hint error |
|
@esr360 fixed errors and made a couple more changes |
|
|
||
| exports.component = (query, operator, target = domNodes) => component({ | ||
| target, | ||
| module, |
There was a problem hiding this comment.
module, is the same as module: module, ?!?
There was a problem hiding this comment.
Yeah, if you just pass the identifier you get that as the key and the value is the value of the variable
There was a problem hiding this comment.
There was a problem hiding this comment.
| * @param {Object} [parser] - custom parser to use for configuration | ||
| * @returns {*} | ||
| */ | ||
| export function getOptions ({ config = {}, parser, custom = {} } = {}) { |
There was a problem hiding this comment.
Why ({ config = {}, parser, custom = {} } = {}) { instead of (config = {}, parser, custom = {}) {?
There was a problem hiding this comment.
Using named parameters is just a good habit to get into.
They allow you to pass arguments in at any position, so it's one less thing that can go wrong.
Partial application (not always using all parameters) is simpler since you don't need to ever do anything like: someFunc(arg1, null, arg3).
You can also easily rename them too: ({ arg: someArg }) => {}
There was a problem hiding this comment.
I mean it's technically just destructuring an object but it's basically named params
There was a problem hiding this comment.
Also means you can make the params non optional and throw an error by just leaving out the = {} at the very end
There was a problem hiding this comment.
After like an hour reading I get it now! It just looks weird having things like = {} } = {}) { in your code but yeah it makes sense
|
Will pull it and run a smoke bomb local test to ensure it's all good then will grit push submerge the PR |
No description provided.