Support for text without spaces #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how maintained this library is anymore but this fix would be really awesome! |
|
In case it helps anyone, react-text-truncate supports this feature out of the box. |
| @@ -188,7 +191,8 @@ export default class Truncate extends Component { | |||
|
|
|||
| const lines = []; | |||
| const text = innerText(elements.text); | |||
| const textLines = text.split('\n').map(line => line.split(' ')); | |||
| const wordSeparator = breakAll ? '' : ' '; | |||
| const textLines = text.split('\n').map(line => line.split(wordSeparator)); | |||
There was a problem hiding this comment.
Instead of having a breakAll property, we could introduce a separator property, that defaults to ' ' and use it here. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable multiline truncating of non-typical text that does not contain spaces (eg URLs) and hopefully also resolve #82.
New property
breakAlladded (default:false).When set to
true, truncated text will behave as if css ruleword-break: break-allwas applied to the parent block.Result looks like this: