Skip to content

Commit

Permalink
Merge pull request #9 from llnagy76/various_modifications
Browse files Browse the repository at this point in the history
Various modifications
  • Loading branch information
llnagy76 committed Nov 17, 2023
2 parents 791ea00 + 81dcaa7 commit a18c2c2
Show file tree
Hide file tree
Showing 13 changed files with 28 additions and 9 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ To install from [GitHub](https://github.com/OneIdentity/ansible-privilege-manage

Using `ansible-galaxy` command:
```bash
ansible-galaxy collection install https://github.com/OneIdentity/ansible-privilege-manager/releases/download/v0.1.3/oneidentity-privilege_manager-0.1.3.tar.gz
ansible-galaxy collection install https://github.com/OneIdentity/ansible-privilege-manager/releases/download/v0.1.4/oneidentity-privilege_manager-0.1.4.tar.gz
```

The collection can also be added to a project's `requirements.yml` file
```yaml
---
collections:
- name: https://github.com/OneIdentity/ansible-privilege-manager/releases/download/v0.1.3/oneidentity-privilege_manager-0.1.3.tar.gz
- name: https://github.com/OneIdentity/ansible-privilege-manager/releases/download/v0.1.4/oneidentity-privilege_manager-0.1.4.tar.gz
```

and installed using the `ansible-galaxy` command. This method allows all required collections for a project to be specified in one place and installed with one command.
Expand Down Expand Up @@ -110,7 +110,7 @@ For local build and installation, you can clone the Git repository, build the co
The build command will generate an Ansible Galaxy collection artifact with a `tar.gz` file extension, sample output will look like the following:

```
Created collection for oneidentity.privilege_manager at /home/user/ansible-privilege-manager/oneidentity-privilege_manager-0.1.3.tar.gz
Created collection for oneidentity.privilege_manager at /home/user/ansible-privilege-manager/oneidentity-privilege_manager-0.1.4.tar.gz
```

`Pleae note the path shown above is just an example, the path to your build artifact will be in the root directory of the cloned repository.`
Expand All @@ -120,14 +120,14 @@ For local build and installation, you can clone the Git repository, build the co
Using `ansible-galaxy` command:

```bash
ansible-galaxy collection install /home/user/ansible-privilege-manager/oneidentity-privilege_manager-0.1.3.tar.gz
ansible-galaxy collection install /home/user/ansible-privilege-manager/oneidentity-privilege_manager-0.1.4.tar.gz
```

The collection can also be added to a project's `requirements.yml` file
```yaml
---
collections:
- name: /home/user/ansible-privilege-manager/oneidentity-privilege_manager-0.1.3.tar.gz
- name: /home/user/ansible-privilege-manager/oneidentity-privilege_manager-0.1.4.tar.gz
```

and installed using the `ansible-galaxy` command. This method allows all required collections for a project to be specified in one place and installed with one command.
Expand Down
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace: oneidentity
name: privilege_manager

# Semantic versioning compliant version designation
version: "0.1.3"
version: "0.1.4"

# The path do the Markdown(.md) readme file
readme: README.md
Expand Down
3 changes: 2 additions & 1 deletion plugins/modules/software_pkgs.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@
'x86_64': 'solaris-intel',
'amd64': 'solaris-intel',
'sparc': 'solaris-sparc',
'sparc64': 'solaris-sparc'
'sparc64': 'solaris-sparc',
'sun4v': 'solaris-sparc'
},
'darwin': {
'x86_64': 'macosx-x86_64'
Expand Down
2 changes: 1 addition & 1 deletion roles/common/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ All of the variables shown below have a default value but can be overridden to s
sudo_plugin
```

* `software_tmp_dir` sets the temporary directory on Ansible hosts for storing files that need to be copied over to the hosts during software deployment operations. The directory is created if it doesn't exist and is removed after all operations are completed.
* `software_tmp_dir` sets the temporary directory on Ansible hosts for storing files that need to be copied over to the hosts during software deployment operations. The directory is created if it doesn't exist.

Default value is:
```yaml
Expand Down
2 changes: 1 addition & 1 deletion roles/common/vars/main.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---

collection_version: '0.1.3'
collection_version: '0.1.4'
2 changes: 2 additions & 0 deletions roles/join/tasks/generate_reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@
delegate_to: "{{ join_reports_host }}"
run_once: true
changed_when: false
vars:
ansible_become: false
2 changes: 2 additions & 0 deletions roles/preflight/tasks/generate_reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@
delegate_to: "{{ preflight_reports_host }}"
run_once: true
changed_when: false
vars:
ansible_become: false
2 changes: 2 additions & 0 deletions roles/preflight/tasks/utils/check_package_directory.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
delegate_to: "{{ software_host }}"
failed_when: false
register: software_pkgs
vars:
ansible_become: false

# Fail if there was a message returned
- fail:
Expand Down
2 changes: 2 additions & 0 deletions roles/software/tasks/check_package_directory.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
delegate_to: "{{ software_host }}"
failed_when: false
register: software_pkgs
vars:
ansible_become: false

# Fail if there was a message returned
- fail:
Expand Down
2 changes: 2 additions & 0 deletions roles/software/tasks/generate_reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@
delegate_to: "{{ software_reports_host }}"
run_once: true
changed_when: false
vars:
ansible_become: false
2 changes: 2 additions & 0 deletions roles/sudo_policy_for_unix_host/tasks/generate_reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@
delegate_to: "{{ sudo_policy_for_unix_host_reports_host }}"
run_once: true
changed_when: false
vars:
ansible_become: false
4 changes: 4 additions & 0 deletions roles/sudoers/tasks/gather_sudoers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
when: sudoers_sudoers_mode == 'inline'
delegate_to: localhost
register: result
vars:
ansible_become: false

# Fail if there was a message returned
- fail:
Expand All @@ -37,4 +39,6 @@
warn: false
when: sudoers_sudoers_mode == 'inline'
delegate_to: localhost
vars:
ansible_become: false

2 changes: 2 additions & 0 deletions roles/sudoers/tasks/generate_reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@
delegate_to: "{{ sudoers_reports_host }}"
run_once: true
changed_when: false
vars:
ansible_become: false

0 comments on commit a18c2c2

Please sign in to comment.