Skip to content

Commit

Permalink
feat: useDappApproveAction support close window after resolved (#2704)
Browse files Browse the repository at this point in the history
  • Loading branch information
qwang1113 committed Mar 14, 2023
1 parent 6414f84 commit a4de502
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/kit/src/hooks/useDappApproveAction.ts
Expand Up @@ -12,11 +12,13 @@ function useDappApproveAction({
id,
getResolveData,
closeOnError,
closeWindowAfterResolved,
}: {
id: number | string;
// Case of rejection only
getResolveData?: () => Promise<any> | any;
closeOnError?: boolean;
closeWindowAfterResolved?: boolean;
}) {
const isExtStandaloneWindow = platformEnv.isExtensionUiStandaloneWindow;
const [rejectError, setRejectError] = useState<Error | null>(null);
Expand Down Expand Up @@ -53,13 +55,18 @@ function useDappApproveAction({
data,
});
close?.();
if (isExtStandaloneWindow && closeWindowAfterResolved) {
setTimeout(() => {
window.close();
}, 0);
}
} catch (error) {
console.error('getResolveData ERROR:', error);
setRejectError(error as Error);
throw error;
}
},
[getResolveData, id],
[getResolveData, id, isExtStandaloneWindow, closeWindowAfterResolved],
);

useEffect(() => {
Expand Down
1 change: 1 addition & 0 deletions packages/kit/src/views/ManageNetworks/SwitchRpc/index.tsx
Expand Up @@ -99,6 +99,7 @@ export function SwitchRpcModal() {
const queryInfo = useDappParams();
const dappApprove = useDappApproveAction({
id: queryInfo.sourceInfo?.id ?? '',
closeWindowAfterResolved: true,
});

const { result, loading } = useAsync(
Expand Down

0 comments on commit a4de502

Please sign in to comment.