Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathfinding 1.20.5 (Minestom/Minestom#2153) #59

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

TheMeinerLP
Copy link
Collaborator

Proposed changes

This PR deals with the upstream changes regarding pathfinding. The changes are considered externally and are to be tested separately.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

iam4722202468 and others added 2 commits June 11, 2024 11:02
* pathfinding

* mutablepoint fix in player

(cherry picked from commit c185337)
@TheMeinerLP TheMeinerLP changed the title Pathfinding 1.20.5 (#2153) Pathfinding 1.20.5 (Minestom/Minestom#2153) Jun 11, 2024
@theEvilReaper theEvilReaper requested a review from a team as a code owner June 11, 2024 13:28
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.2% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants