Fix crash related to Amazon AppStore SDK #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nan-li
force-pushed
the
fix/amazon_iap_crash
branch
from
56a3199
to
01307a0
Compare
register listener on main thread for appstore sdk v3.x * Amazon IAP SDK v2.x is deprecated and developers are encouraged to use AppStore SDK v3.x. Users were getting a crash on initialization. * To support the AppStore SDK, `PurchasingService.registerListener()` must run on the main thread. * Note: We do still support the existing implementation for IAP SDK v2.x, and we won't register on the main thread.
* Remove dependency `in-app-purchasing-2.0.1.jar` which is from 2015, and instead compile against its replacement `amazon-appstore-sdk` v3.x. This change currently makes no difference at compile time, as this crash was only encountered at runtime, but still good to update this dependency to what users are more likely to be currently using.
nan-li
force-pushed
the
fix/amazon_iap_crash
branch
from
01307a0
to
590331b
Compare
emawby
approved these changes
Aug 10, 2022
Merged
This was referenced Aug 16, 2022
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix crash for users of Amazon AppStore SDK v3.x.
Details
Motivation
PurchasingService.registerListener()must run on the main thread. See documentation.Other Changes
in-app-purchasing-2.0.1.jarwhich is from 2015, and instead compile against its replacementamazon-appstore-sdkv3.x. This change currently makes no difference at compile time, as this crash was only encountered at runtime, but still good to update this dependency to what users are more likely to be currently using.Scope
Only affects users of Amazon's AppStore SDK v3.x, for whom the OneSignal SDK was not working in the first place. So even though there is a danger zone to calling this method on the main thread, it is still preferable.
Note that
onAppLostFocus()can triggerPurchasingService.registerListener()in certain cases. See here. We will need to monitor or make changes.^⚠️ I am concerned if this will pose a significant issue.
Testing
Unit testing
There are no existing unit tests for Amazon purchases. No new tests are added.
Note: Unrelated, but test
testNotificationProcessingAndForegroundHandler_displayCalled_noMutateIdis failing. Looks like due to changes in #1597Manual testing
Environment: Android Studio 2020.3.1.
Device: Pixel 3a emulator - API 30
App: OneSignal demo app in the SDK
First, reproduced the crash by using amazon appstore v3.0.1 and v3.0.3 (the latest version at time of writing).
Then, confirm IAP SDK works the same as before by using
in-app-purchasing-2.0.1.jar(these are not available on Maven).Affected code checklist
Checklist
Overview
Testing
Final pass
This change is