Fix In-App Message auto-dismiss crash #1846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix In-App Message auto-dismiss crash.
Details
Manually closing an auto-dismiss In-App Message before the timer runs out resulted in a NullPointerException crash. Replacing
messageView
non-null assertion!!
with safe call operator?
prevents crash.Motivation
Prevent NullPointerException crash when auto-dismiss IAM is manually closed.
Scope
Non-null assertion
!!
replacement with safe call operator?
only applied to themessageView
variable withinshowMessageView
method. Similar safe call operator replacements may be made to other code blocks in the future.Testing
Manual testing
Tested manually dismissing the auto-dismiss IAM before the timer runs out on Pixel 6 emulator running Android 13 as well as Pixel 7 emulator running Android 14.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is