Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent modification exception #1849

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Sep 22, 2023

Description

One Line Summary

Fix concurrentModificationException on the Model.kt data property

Details

I received a concurrentModificationException on the Model.kt data property when running the toJson() method
This PR makes the data property synchronized.

Motivation

Fix crash

Scope

All models

Testing

Unit testing

none

Manual testing

I was not able to reproduce but I made the fix because I experienced it in testing

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby merged commit a5c88de into user-model/main Sep 25, 2023
1 of 2 checks passed
@emawby emawby deleted the fix/concurrent_modification_exception branch September 25, 2023 23:01
@jennantilla jennantilla mentioned this pull request Sep 25, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…xception

Fix concurrent modification exception
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…xception

Fix concurrent modification exception
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
…xception

Fix concurrent modification exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants