Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update work-runtime dependency version #1890

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Nov 2, 2023

Description

One Line Summary

Update work-runtime dependency version to 2.8.1

Details

Prevents gradle crash with latest version of WorkManager

Motivation

Reported in #1889

Scope

androidx.work:work-runtime dependency

Testing

Unit testing

Built app on Android 12 and 13 emulators and ran unit tests with updated dependency version to ensure no issues.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Prevents gradle crash with latest version of WorkManager
@rubenferreira97
Copy link

This PR seems incomplete. Check this comment for details.

jennantilla added a commit that referenced this pull request Jan 11, 2024
Work manager dependency was updated in #1890 but missed updating the implementation
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Work manager dependency was updated in #1890 but missed updating the implementation
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Work manager dependency was updated in #1890 but missed updating the implementation
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Work manager dependency was updated in #1890 but missed updating the implementation
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Work manager dependency was updated in #1890 but missed updating the implementation
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Work manager dependency was updated in #1890 but missed updating the implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gradle crash when using another dependency that uses latest work-runtime version
4 participants