Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update startGetLocation to only run if location is shared #1942

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Fix: Update startGetLocation to only run if location is shared #1942

merged 7 commits into from
Dec 28, 2023

Commits on Dec 13, 2023

  1. Update startGetLocation to only run if location is shared

    @jennantilla
    jennantilla committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c0b8592 View commit details
    Browse the repository at this point in the history

  2. Fix linting error

    @jennantilla
    jennantilla committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7bc4aa3 View commit details
    Browse the repository at this point in the history

  3. Update startGetLocation to return early if isShared is false

    @jennantilla
    jennantilla committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ec79584 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Update isShared default to false

    @jennantilla
    jennantilla committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f275b24 View commit details
    Browse the repository at this point in the history

  2. Allow for mid-session update of location permission

    @jennantilla
    jennantilla committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a7d7a72 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Remove early return for requestPermission 

    Since isShared now defaults to false, remove early return and add logging to update isShared to true.
    @jennantilla
    jennantilla committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    fc842b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Update LocationManager 

    - Change log to warn vs. error
- Access and save to constant PREFS_OS_LOCATION_SHARED
    @jennantilla
    jennantilla committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8b0b74b View commit details
    Browse the repository at this point in the history