[Tests] Upgrade to Junit5 #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
force-pushed
the
tests/upgrade-to-junit5
branch
from
a2b6c1a
to
4dca329
Compare
JUnit 5 supports better test result output with Kotest and number of other features. JUnit 4 is not get any new features, and at this point probably only gets security fixes.
jkasten2
force-pushed
the
tests/upgrade-to-junit5
branch
from
4dca329
to
727e3bc
Compare
nan-li
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
The testhelpers module still uses junitVersion = '4.13.2'.
Because that module does not have tests, unlike the other modules in this PR?
Robolectric only has a JUnit 4 interface, however we are adapting it via RobolectricExtension.kt. However this means we still require a reference to JUnit4 in this specific testhelpers to do this.
|
@nan-li Good catch! I completely missed this module. I pushed a commit to address what I could here, details in the commit and below. I was able to update it's Kotest usage to JUnit5, but had to keep a JUnit4 reference for the code that adapts Robolectric's JUnit4 interface to Kotest's JUnit5 interface. |
nan-li
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
JUnit 5 supports better test result output with Kotest and a number of other features.
Motivation
Scope
Only unit tests, only upgrading JUnit 4 -> 5.
Testing
Unit testing
Unit tests pass locally and on CI
Manual testing
No production source was changed.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is