Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Player Model] Fix OSTaskController crashing on LinkedBlockingQueue.poll() on Android 12 #2062

Merged

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Apr 23, 2024

Description

One Line Summary

Fix rare Android 12 crash with OSTaskController using ConcurrentLinkedQueue.

Details

Android 12 has a bug where ConcurrentLinkedQueue.poll() can return the wrong value. This is rare but results in a few crash reports in OSTaskController, see issue #1761.
To workaround this issue we switched to LinkedBlockingQueue. We have seen reports of crashing in OSTaskController, but we also are also addressing the usages in UserStateSynchronizer.

Related

Issue fixes issue #1761.
ConcurrentLinkedQueue is not used in 5.x.x, so no changes are need there.

Motivation

Crashes are rare, and limited to Android 12, but SDK should cause any crashes.

Scope

Effects some Queues used in OSTaskController and UserStateSynchronizer.

Testing

Unit testing

player-model-main unit tests are not running currently.

Manual testing

Tested on an Android 14 emulator. Ensuring the device subscribes and tags can be added.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Android 12 has a bug where ConcurrentLinkedQueue.poll() can return the
wrong value. This is rare but results in a few crash reports in
OSTaskController, see issue #1761.
To workaround this issue we switched to LinkedBlockingQueue.
Switch renaming usages of ConcurrentLinkedQueue to LinkedBlockingQueue
to avoid a possible crash on Android 12, due to a bug it has with it.
While we haven't gotten any crash reports of these usages they could
happen.
See previous commit, ef581d2, for more
details.
@jkasten2 jkasten2 changed the title [WIP][Player Model] Fix OSTaskController crashing on LinkedBlockingQueue.poll() [Player Model] Fix OSTaskController crashing on LinkedBlockingQueue.poll() Apr 23, 2024
@jkasten2 jkasten2 changed the title [Player Model] Fix OSTaskController crashing on LinkedBlockingQueue.poll() [Player Model] Fix OSTaskController crashing on LinkedBlockingQueue.poll() on Android 12 Apr 24, 2024
@jkasten2 jkasten2 merged commit 711f468 into player-model-main Apr 25, 2024
1 of 2 checks passed
@jkasten2 jkasten2 deleted the fix/android-12-concurrentlinkedqueue-workaround branch April 25, 2024 16:52
@jkasten2 jkasten2 mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants