Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location and IAM modules to native references #70

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Oct 9, 2023

Description

One Line Summary

This fixes a build issue when consuming the SDK as a nuget package.

Fixes #68

Details

The XCFrameworks for new modules location and IAMs were not included in the native references section of the binding project.

Motivation

allow builds

Testing

Unit testing

none

Manual testing

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This fixes a build issue when consuming the SDK as a nuget package.
@emawby emawby merged commit 410a333 into user-model/main Oct 9, 2023
1 check passed
@emawby emawby deleted the fix/ios_build branch October 9, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question]: Problem build project Xamarin iOS (vs Mac 2022) with OnesignalSdk.DotNet
2 participants