Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the namespace property in build.gradle if the field is necessary. #765

Merged
merged 2 commits into from Jan 24, 2024

Conversation

Marco4763
Copy link
Contributor

@Marco4763 Marco4763 commented Oct 12, 2023

Description

One Line Summary

This PR provide the package namespace if the AGP is equal or higher then 8.

Details

Motivation

By adding the namespace condition for AGP 8 and higher, this fix the issue [Bug]: AGP 8 not supported #764

Testing

Manual testing

Tested during the Gradle sync with AGP 9

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@Marco4763
Copy link
Contributor Author

Please review: @jkasten2, @emawby.

android/build.gradle Outdated Show resolved Hide resolved
@nan-li nan-li merged commit 8f00a35 into OneSignal:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants