Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android User calls to always resolve #800

Merged
merged 2 commits into from Dec 14, 2023

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Dec 11, 2023

Description

One Line Summary

Resolve all Android user namespace methods over the bridge as some were missed.

Details

Motivation

Fixes #799
Fixes #789

Scope

Resolve all User namespace methods over the Android bridge, some of them were missed like addTag or removeTag. This was only for people using await with these methods and waiting on the response, doesn't change any implementation details.

Testing

Unit testing

None

Manual testing

Android Nexus S Emulator API 33, tested with calling addTag with await and seeing that it resolves after these changes.

await OneSignal.User.addTagWithKey("test2", "val2");

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @emawby, @jennantilla, @jinliu9508, and @jkasten2)

* A few methods were missing the `replySuccess` to resolve the call from the app developer.
@nan-li nan-li merged commit 34b8ca1 into user_model/main Dec 14, 2023
2 of 3 checks passed
@nan-li nan-li deleted the fix_android_addtags_await branch December 14, 2023 21:20
@nan-li nan-li mentioned this pull request Jan 30, 2024
nan-li added a commit that referenced this pull request Jan 31, 2024
Fix Android User calls to always resolve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants