Skip to content
This repository has been archived by the owner on Oct 31, 2022. It is now read-only.

Commit

Permalink
Upgrade messaging when iid updates to 20.1.0+
Browse files Browse the repository at this point in the history
* Also updated OneSignal-Android-SDK version so tests pass
  • Loading branch information
jkasten2 committed Apr 30, 2020
1 parent 6f6f915 commit a6422e8
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,21 @@ class GradleProjectPlugin implements Plugin<Project> {
],
'20.0.0': [
'com.google.firebase:firebase-messaging': '20.0.0'
],
'20.1.0': [
'com.google.firebase:firebase-messaging': '20.1.1'
],
'20.1.1': [
'com.google.firebase:firebase-messaging': '20.1.1'
],
'20.1.2': [
'com.google.firebase:firebase-messaging': '20.1.1'
],
'20.1.4': [
'com.google.firebase:firebase-messaging': '20.1.4'
],
'20.1.5': [
'com.google.firebase:firebase-messaging': '20.1.4'
]
],
'com.google.android.gms:play-services-measurement-base': [
Expand Down
21 changes: 20 additions & 1 deletion src/test/groovy/com/onesignal/androidsdk/MainTest.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class MainTest extends Specification {

then:
results.each {
assert it.value.contains('com.onesignal:OneSignal:[3.8.3, 3.99.99] -> 3.12.6')
assert it.value.contains('com.onesignal:OneSignal:[3.8.3, 3.99.99] -> 3.13.0')
}
}

Expand Down Expand Up @@ -947,6 +947,25 @@ class MainTest extends Specification {
}
}

def 'when firebase-iid:20.1.6 ensure firebase-messaging:20.1.4'() {
def compileLines = """\
compile 'com.google.firebase:firebase-messaging:20.0.0'
compile 'com.google.firebase:firebase-iid:20.1.6'
"""

when:
def results = runGradleProject([
skipGradleVersion: GRADLE_OLDEST_VERSION,
compileLines : compileLines
])

then:
assert results // Asserting existence and contains 1+ entries
results.each {
assert it.value.contains('com.google.firebase:firebase-messaging:20.0.0 -> 20.1.4')
}
}

def 'when firebase-core:16.0.9 ensure firebase-messaging:17.6.0'() {
def compileLines = """\
compile 'com.google.firebase:firebase-messaging:17.0.0'
Expand Down

1 comment on commit a6422e8

@mikechoch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please sign in to comment.